Skip to content

Commit 9ac640c

Browse files
committed
Use HDfree() instead of free() for HDrealpath-allocated canonical paths
Replace bare free() calls with HDfree() when releasing canonical_dir and canonical_file buffers returned by HDrealpath, to conform with HDF5 library memory management conventions.
1 parent 1a89123 commit 9ac640c

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

src/H5PLsig.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -705,7 +705,7 @@ H5PL__load_keys_from_directory(const char *dir_path)
705705
/* File might not exist yet in some cases, but for key files it must exist */
706706
H5PL_SIG_DEBUG_PRINT("WARNING: Cannot resolve key file path %s: %s\n", file_path,
707707
strerror(errno));
708-
free(canonical_dir);
708+
HDfree(canonical_dir);
709709
H5MM_xfree(file_path);
710710
continue;
711711
}
@@ -718,15 +718,15 @@ H5PL__load_keys_from_directory(const char *dir_path)
718718
H5PL_SIG_DEBUG_PRINT(
719719
"WARNING: Path traversal detected - %s resolves outside keystore directory\n",
720720
entry->d_name);
721-
free(canonical_dir);
722-
free(canonical_file);
721+
HDfree(canonical_dir);
722+
HDfree(canonical_file);
723723
H5MM_xfree(file_path);
724724
continue;
725725
}
726726
}
727727

728-
free(canonical_dir);
729-
free(canonical_file);
728+
HDfree(canonical_dir);
729+
HDfree(canonical_file);
730730
}
731731

732732
/* Skip symlinks */

0 commit comments

Comments
 (0)