Skip to content

Commit e4cfcdf

Browse files
committed
Remove debugging steps from signed-plugins CI workflow
Remove the OpenSSL version check, pre-seeded build key files, and redundant ci-keystore ACL restriction that were added during debugging but are not needed for correct test operation.
1 parent 5c1fb03 commit e4cfcdf

1 file changed

Lines changed: 1 addition & 17 deletions

File tree

.github/workflows/signed-plugins.yml

Lines changed: 1 addition & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -84,23 +84,13 @@ jobs:
8484
run: |
8585
brew install openssl@3
8686
87-
- name: Check OpenSSL Version (Windows)
88-
if: runner.os == 'Windows'
89-
shell: pwsh
90-
run: |
91-
& openssl version
92-
9387
- name: Generate test RSA key pair (Unix)
9488
if: runner.os != 'Windows'
9589
run: |
9690
openssl genrsa -out ci-test-private.pem 2048
9791
openssl rsa -in ci-test-private.pem -pubout -out ci-test-public.pem
9892
mkdir -p ci-keystore
9993
cp ci-test-public.pem ci-keystore/
100-
# Pre-seed build keys so CMake reuses the CI key pair (avoids key mismatch)
101-
mkdir -p build
102-
cp ci-test-private.pem build/private.pem
103-
cp ci-test-public.pem build/public.pem
10494
10595
- name: Generate test RSA key pair (Windows)
10696
if: runner.os == 'Windows'
@@ -110,10 +100,6 @@ jobs:
110100
& openssl rsa -in ci-test-private.pem -pubout -out ci-test-public.pem
111101
New-Item -ItemType Directory -Force -Path ci-keystore
112102
Copy-Item ci-test-public.pem ci-keystore/
113-
# Pre-seed build keys so CMake reuses the CI key pair (avoids key mismatch)
114-
New-Item -ItemType Directory -Force -Path build
115-
Copy-Item ci-test-private.pem build\private.pem
116-
Copy-Item ci-test-public.pem build\public.pem
117103
118104
- name: Configure CMake
119105
shell: bash
@@ -139,16 +125,14 @@ jobs:
139125
- name: Build
140126
run: cmake --build build --parallel 4 --config ${{ matrix.config.build_type }}
141127

142-
- name: Copy OpenSSL DLLs and secure keystores (Windows)
128+
- name: Copy OpenSSL DLLs (Windows)
143129
if: runner.os == 'Windows'
144130
shell: pwsh
145131
run: |
146132
Copy-Item "C:\Program Files\OpenSSL\bin\libcrypto-3-x64.dll" build\bin\${{ matrix.config.build_type }}\
147133
Copy-Item "C:\Program Files\OpenSSL\bin\libssl-3-x64.dll" build\bin\${{ matrix.config.build_type }}\
148134
# Restrict test keystore ACLs so permission check passes
149135
icacls build\test_keystore /inheritance:r /grant "${env:USERNAME}:(OI)(CI)F" /grant "Administrators:(OI)(CI)F"
150-
# Also restrict the compile-time keystore (ci-keystore)
151-
icacls ci-keystore /inheritance:r /grant "${env:USERNAME}:(OI)(CI)F" /grant "Administrators:(OI)(CI)F"
152136
153137
- name: Run Tests
154138
shell: bash

0 commit comments

Comments
 (0)