Merge pull request #4632 from Roardom/remove-group-index

(Remove) Public view of all users in group

Author: Roardom

app/Http/Controllers/StatsController.php

@@ -261,17 +261,6 @@ public function groups(): \Illuminate\Contracts\View\Factory|\Illuminate\View\Vi
         ]);
     }
 
-    /**
-     * Show Extra-Stats Groups.
-     */
-    public function group(int $id): \Illuminate\Contracts\View\Factory|\Illuminate\View\View
-    {
-        return view('stats.groups.group', [
-            'group' => Group::findOrFail($id),
-            'users' => User::with(['group'])->withTrashed()->where('group_id', '=', $id)->latest()->paginate(100),
-        ]);
-    }
-
     /**
      * Show Group Requirements.
      */

resources/views/blocks/online.blade.php

@@ -27,14 +27,13 @@ class="{{ config('other.font-awesome') }} fa-exclamation-circle text-orange"
         <ul style="column-width: 200px; column-gap: 1rem; list-style-type: none; padding: 0">
             @foreach ($groups as $group)
                 <span class="user-tag" style="padding: 4px 8px; display: block">
-                    <a
+                    <span
                         class="user-tag__link {{ $group->icon }}"
-                        href="{{ route('group', ['id' => $group->id]) }}"
                         style="color: {{ $group->color }}"
                         title="{{ $group->name }}"
                     >
                         {{ $group->name }}
-                    </a>
+                    </span>
                 </span>
             @endforeach
         </ul>

resources/views/stats/groups/group.blade.php

@@ -40,16 +40,15 @@
                     @foreach ($groups as $group)
                         <tr>
                             <td style="min-width: 20%">
-                                <a
-                                    href="{{ route('group', ['id' => $group->id]) }}"
+                                <span
                                     style="
                                         color: {{ $group->color }};
                                         background-image: {{ $group->effect }};
                                     "
                                 >
                                     <i class="{{ $group->icon }}"></i>
                                     {{ $group->name }}
-                                </a>
+                                </span>
                             </td>
                             <td>
                                 @if ($group->autogroup)

resources/views/stats/groups/groups-requirements.blade.php

@@ -36,13 +36,10 @@
                     @foreach ($groups as $group)
                         <tr>
                             <td>
-                                <a
-                                    href="{{ route('group', ['id' => $group->id]) }}"
-                                    style="color: {{ $group->color }}"
-                                >
+                                <span style="color: {{ $group->color }}">
                                     <i class="{{ $group->icon }}"></i>
                                     {{ $group->name }}
-                                </a>
+                                </span>
                             </td>
                             <td>{{ $group->users_count }}</td>
                         </tr>

resources/views/stats/groups/groups.blade.php

@@ -309,14 +309,13 @@ class="form__button form__button--text"
                         <tr>
                             <td>
                                 <span class="user-tag">
-                                    <a
+                                    <span
                                         class="user-tag__link {{ $groups->first()->icon }}"
-                                        href="{{ route('group', ['id' => $groups->first()->id]) }}"
                                         style="color: {{ $groups->first()->color }}"
                                         title="{{ $groups->first()->name }}"
                                     >
                                         {{ $groups->first()->name }}
-                                    </a>
+                                    </span>
                                 </span>
                             </td>
                             <td style="text-align: right">{{ $groups->count() }}</td>

resources/views/user/invite-tree/index.blade.php

@@ -905,14 +905,13 @@ class="{{ config('other.font-awesome') }} fa-times text-red"
                             <dd>
                                 @if (null !== ($group = \App\Models\Group::find($externalUser['group_id'])))
                                     <span class="user-tag">
-                                        <a
+                                        <span
                                             class="user-tag__link {{ $group->icon }}"
-                                            href="{{ route('group', ['id' => $group->id]) }}"
                                             style="color: {{ $group->color }}"
                                             title="{{ $group->name }}"
                                         >
                                             {{ $group->name }}
-                                        </a>
+                                        </span>
                                     </span>
                                 @else
                                     Unrecognized group_id: {{ $externalUser['group_id'] }}

resources/views/user/profile/show.blade.php

@@ -200,7 +200,6 @@
             Route::get('/torrent/dead', [App\Http\Controllers\StatsController::class, 'dead'])->name('dead');
             Route::get('/request/bountied', [App\Http\Controllers\StatsController::class, 'bountied'])->name('bountied');
             Route::get('/groups', [App\Http\Controllers\StatsController::class, 'groups'])->name('groups');
-            Route::get('/groups/group/{id}', [App\Http\Controllers\StatsController::class, 'group'])->name('group')->whereNumber('id');
             Route::get('/groups/requirements', [App\Http\Controllers\StatsController::class, 'groupsRequirements'])->name('groups_requirements');
             Route::get('/languages', [App\Http\Controllers\StatsController::class, 'languages'])->name('languages');
             Route::get('/themes', [App\Http\Controllers\StatsController::class, 'themes'])->name('themes');

routes/web.php

@@ -125,23 +125,6 @@
     // TODO: perform additional assertions
 });
 
-test('group returns an ok response', function (): void {
-    $this->markTestIncomplete('This test case was generated by Shift. When you are ready, remove this line and complete this test case.');
-
-    $group = Group::factory()->create();
-    $users = User::factory()->times(3)->create();
-    $user = User::factory()->create();
-
-    $response = $this->actingAs($user)->get(route('group', ['id' => $id]));
-
-    $response->assertOk();
-    $response->assertViewIs('stats.groups.group');
-    $response->assertViewHas('users', $users);
-    $response->assertViewHas('group', $group);
-
-    // TODO: perform additional assertions
-});
-
 test('groups returns an ok response', function (): void {
     $this->markTestIncomplete('This test case was generated by Shift. When you are ready, remove this line and complete this test case.');