Cannot add Distributor/Region after upload if they were not set initially (Full Disc uploads)

[tiberio87]

Description

When uploading a Full Disc movie release, the uploader correctly allows selecting Distributor and Region.
However, if the user forgets to set these fields during the initial upload, it becomes impossible to add them later from the Edit page.

The Edit page will only show Distributor and Region if they were filled in during the upload.
If they were left empty, the fields will not appear at all, preventing the user from adding this metadata afterwards.

Steps to Reproduce

1. Go to Upload > Movie.

2. Select a Full Disc source (e.g., DISK).

3. Leave Distributor and/or Region empty.

4. Complete the upload.

5. Open the Edit page for the uploaded torrent.

6. Notice that Distributor and Region fields are missing and cannot be added.

Expected Behavior

For Full Disc releases, the Edit page should always allow the user to add or edit Distributor and Region, even if they were not set during the upload.

Actual Behavior

If the fields were blank during upload, they disappear completely on the Edit page, making it impossible to set them afterwards.

Impact

Users cannot correct or complete metadata for Full Disc uploads after submitting the torrent.
This forces them to reupload the entire torrent if they want proper Distributor/Region information.

Environment

UNIT3D version: 9.1.7

PHP & Platform: 8.4.4 - ubuntu 22.04.2

Laravel: 12.26.4

Screenshots

Pre upload

After upload

[Roardom]

As stupid as it may be, it only works if your type is named "Full Disc":

UNIT3D/resources/views/torrent/edit.blade.php

Line 162 in f3fc849

x-show="(cats[cat].type === 'movie' || cats[cat].type === 'tv') && types[type].name === 'Full Disc'"

There's no other way for now to tell if the uploaded torrent is supposed to have distributor/region selected or not.

[EkoNesLeg]

I patched this a couple of years ago for a site that required more specificity than just "full disc".

[tiberio87]

Hi, thanks for the clarification!
Renaming the category to Full Disc does solve the issue, and the Distributor/Region fields correctly appear in the Edit page.
However, I would like to ask if there is any plan to make these fields editable even when using a custom category name, such as "DISK", as long as the release is still considered a Full Disc upload.
Right now, if the category name differs from “Full Disc”, the Edit page hides the Distributor/Region fields completely, even though the upload itself is a Full Disc release.
It would be useful if the edit functionality were based on the source type (e.g. Full Disc upload) rather than the exact category name, so that custom naming would not break the ability to edit these parameters.
Is this behavior expected, or could support for editing Distributor/Region with custom category names be added?
Thanks again!

[Roardom]

That's why I said the current implementation is stupid :)

However, it's not based on the category name - but the type name, so not sure why you experienced it with categories. There's a few more discrepancies like this such as bdinfo box should only be visible for full discs, but only blu-rays. And not just 1080p ones since 720p and SD blu-rays also exist (and what about hd dvds). Meanwhile mediainfo should be visible for any non-discs, but also dvds. Only decent way I can see as to how to fix this is to add requires_distributor and requires_region boolean columns to the types table and use those flags to determine the hiding of distributor/region, but the priority for me to implement that right now is very low.