fix: defer KG rebuild during batch document deletion#2823
fix: defer KG rebuild during batch document deletion#2823danielaskdd wants to merge 1 commit intomainfrom
Conversation
…edundant rebuilds Co-authored-by: danielaskdd <36760595+danielaskdd@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Fixes an issue where batch document deletion causes redundant N Knowledge Graph rebuilds. It introduces a
skip_rebuildflag toadelete_by_doc_id(), allowing batch deletion processes to defer per-document KG rebuilds. Rebuild data (entities, relationships) is returned from deletion and aggregated by the caller. It incorporates the logic from PR 2819 and includes additional checks to ensure fully deleted entities and relationships are not rebuilt with stale data. Adds tests to cover this optimization and its edge cases.PR created automatically by Jules for task 16849260015452852282 started by @danielaskdd