Skip to content

Commit 32e4a7b

Browse files
committed
skip checking lookup functionality tests on CRAN due to flakiness with linux devel environments
1 parent 8143d00 commit 32e4a7b

File tree

3 files changed

+9
-0
lines changed

3 files changed

+9
-0
lines changed

NEWS.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
# verdata 1.0.2
2+
3+
* Removing a test of `mse()` when `lookup_estimates = TRUE`. This was a timing based test that was too flaky to be a reliable indicator of function performance across all test environment. Increasing the time tolerance in update 1.0.1 did not meaningfully resolve this issue as hoped.
4+
15
# verdata 1.0.1
26

37
* Timing test for `mse()` using `lookup_estimates` option uses more generous comparison to ensure that test doesn't fail unnecessarily when estimates are correctly looked up.

tests/testthat/test-estimate_mse.R

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -164,6 +164,7 @@ testthat::test_that("mse function returns errors when inputs are misspecified",
164164

165165
testthat::test_that("lookup function correctly finds strata that have and have not been estimated", {
166166

167+
testthat::skip_on_cran()
167168

168169
local_dir <- system.file("extdata", "right", package = "verdata")
169170
replicates <- read_replicates(local_dir, "reclutamiento", replicate_nums = 1,

tests/testthat/test-lookup_estimates.R

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,8 @@ my_stratum <- tibble::tibble(in_A, in_B) %>%
3838

3939
testthat::test_that("Lookup existing estimates", {
4040

41+
testthat::skip_on_cran()
42+
4143
estrato <- replicates %>%
4244
dplyr::filter(sexo == "HOMBRE",
4345
yy_hecho == 1999,
@@ -54,6 +56,8 @@ testthat::test_that("Lookup existing estimates", {
5456

5557
testthat::test_that("Lookup non existing estimates", {
5658

59+
testthat::skip_on_cran()
60+
5761
estrato <- replicates %>%
5862
dplyr::filter(sexo == "HOMBRE",
5963
yy_hecho == 1998,

0 commit comments

Comments
 (0)