Skip to content

Commit 01f7bb1

Browse files
committed
FactSystem: Cleanup
1 parent 67a2905 commit 01f7bb1

22 files changed

+1601
-1750
lines changed

src/Camera/QGCCameraIO.cc

+4-4
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ QGCCameraParamIO::QGCCameraParamIO(MavlinkCameraControl *control, Fact* fact, Ve
4444
}
4545
connect(&_paramWriteTimer, &QTimer::timeout, this, &QGCCameraParamIO::_paramWriteTimeout);
4646
connect(_fact, &Fact::rawValueChanged, this, &QGCCameraParamIO::_factChanged);
47-
connect(_fact, &Fact::_containerRawValueChanged, this, &QGCCameraParamIO::_containerRawValueChanged);
47+
connect(_fact, &Fact::containerRawValueChanged, this, &QGCCameraParamIO::_containerRawValueChanged);
4848
//-- TODO: Even though we don't use anything larger than 32-bit, this should
4949
// probably be updated.
5050
switch (_fact->type()) {
@@ -226,7 +226,7 @@ QGCCameraParamIO::handleParamAck(const mavlink_param_ext_ack_t& ack)
226226
if(ack.param_result == PARAM_ACK_ACCEPTED) {
227227
QVariant val = _valueFromMessage(ack.param_value, ack.param_type);
228228
if(_fact->rawValue() != val) {
229-
_fact->_containerSetRawValue(val);
229+
_fact->containerSetRawValue(val);
230230
if(_updateOnSet) {
231231
_updateOnSet = false;
232232
_control->factChanged(_fact);
@@ -251,7 +251,7 @@ QGCCameraParamIO::handleParamAck(const mavlink_param_ext_ack_t& ack)
251251
QVariant val = _valueFromMessage(ack.param_value, ack.param_type);
252252
if(_fact->rawValue() != val) {
253253
if(_control->validateParameter(_fact, val)) {
254-
_fact->_containerSetRawValue(val);
254+
_fact->containerSetRawValue(val);
255255
}
256256
}
257257
}
@@ -264,7 +264,7 @@ QGCCameraParamIO::handleParamValue(const mavlink_param_ext_value_t& value)
264264
_paramRequestTimer.stop();
265265
QVariant newValue = _valueFromMessage(value.param_value, value.param_type);
266266
if(_control->incomingParameter(_fact, newValue)) {
267-
_fact->_containerSetRawValue(newValue);
267+
_fact->containerSetRawValue(newValue);
268268
}
269269
_paramRequestReceived = true;
270270
if(_forceUIUpdate) {

src/Camera/VehicleCameraControl.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -1039,7 +1039,7 @@ VehicleCameraControl::_loadSettings(const QDomNodeList nodeList)
10391039
Fact* pFact = new Fact(_compID, factName, factType, this);
10401040
QQmlEngine::setObjectOwnership(pFact, QQmlEngine::CppOwnership);
10411041
pFact->setMetaData(metaData);
1042-
pFact->_containerSetRawValue(metaData->rawDefaultValue());
1042+
pFact->containerSetRawValue(metaData->rawDefaultValue());
10431043
QGCCameraParamIO* pIO = new QGCCameraParamIO(this, pFact, _vehicle);
10441044
QQmlEngine::setObjectOwnership(pIO, QQmlEngine::CppOwnership);
10451045
_paramIO[factName] = pIO;

0 commit comments

Comments
 (0)