Bump clippy to 1.84.0, fix respective lints

Author: schmidma

clippy.toml

@@ -1 +1 @@
-msrv = "1.80.0"
+msrv = "1.84.0"

crates/buffered_watch/src/receiver.rs

@@ -21,7 +21,7 @@ impl<T> Receiver<T> {
     }
 
     /// Borrows the latest value
-    pub fn borrow(&mut self) -> ReceiverGuard<T> {
+    pub fn borrow(&'_ mut self) -> ReceiverGuard<'_, T> {
         let shared = self.shared.read();
         let index = {
             let states = &mut *shared.states.lock();
@@ -38,7 +38,7 @@ impl<T> Receiver<T> {
     }
 
     /// Borrows the latest value and marks the buffer as seen
-    pub fn borrow_and_mark_as_seen(&mut self) -> ReceiverGuard<T> {
+    pub fn borrow_and_mark_as_seen(&'_ mut self) -> ReceiverGuard<'_, T> {
         let shared = self.shared.read();
         let index = {
             let states = &mut *shared.states.lock();

crates/buffered_watch/src/sender.rs

@@ -21,7 +21,7 @@ unsafe impl<T> Send for Sender<T> where T: Send + Sync {}
 
 impl<T> Sender<T> {
     /// Borrows the latest value
-    pub fn borrow(&mut self) -> ReceiverGuard<T> {
+    pub fn borrow(&'_ mut self) -> ReceiverGuard<'_, T> {
         let shared = self.shared.read();
         let index = {
             let states = &mut *shared.states.lock();
@@ -38,7 +38,7 @@ impl<T> Sender<T> {
     }
 
     /// Borrows a buffer to write to
-    pub fn borrow_mut(&mut self) -> SenderGuard<T> {
+    pub fn borrow_mut(&'_ mut self) -> SenderGuard<'_, T> {
         let shared = self.shared.read();
         let index = {
             let states = &mut *shared.states.lock();

crates/code_generation/src/execution.rs

@@ -516,7 +516,7 @@ fn generate_cycler_constructors(cyclers: &Cyclers, mode: CyclerMode) -> TokenStr
         } else {
             Default::default()
         };
-        let error_message = format!("failed to create cycler `{}`", instance);
+        let error_message = format!("failed to create cycler `{instance}`");
 
         quote! {
             #[allow(unused)]
@@ -567,7 +567,7 @@ fn generate_cycler_starts(cyclers: &Cyclers) -> TokenStream {
                 format_ident!("{}_cycler", instance.to_case(Case::Snake));
             let cycler_handle_identifier =
                 format_ident!("{}_handle", instance.to_case(Case::Snake));
-            let error_message = format!("failed to start cycler `{}`", instance);
+            let error_message = format!("failed to start cycler `{instance}`");
             quote! {
                 let #cycler_handle_identifier = #cycler_variable_identifier
                     .start(keep_running.clone())
@@ -644,7 +644,7 @@ fn generate_cycler_replays(cyclers: &Cyclers) -> TokenStream {
         .map(|(_cycler, instance)| {
             let cycler_variable_identifier =
                 format_ident!("{}_cycler", instance.to_case(Case::Snake));
-            let error_message = format!("failed to replay {} cycle", instance);
+            let error_message = format!("failed to replay {instance} cycle");
             quote! {
                 #instance => self.#cycler_variable_identifier.cycle(timestamp, data).wrap_err(#error_message),
             }

crates/control/src/free_kick_signal_filter.rs

@@ -172,7 +172,7 @@ impl FreeKickSignalFilter {
                 time: context.cycle_time.start_time,
                 detected_kicking_team: own_detected_kicking_team,
             });
-            if self.last_time_message_sent.as_ref().map_or(true, |time| {
+            if self.last_time_message_sent.as_ref().is_none_or(|time| {
                 now.duration_since(*time).expect("Time ran backwards") >= *context.message_interval
             }) && context.remaining_amount_of_messages.is_some_and(
                 |remaining_amount_of_messages| {

crates/control/src/localization.rs

@@ -249,7 +249,7 @@ impl Localization {
                         self.hypotheses
                             .clone_from(&self.hypotheses_when_entered_playing);
                     }
-                } else if self.time_when_penalized_clicked.map_or(true, |time| {
+                } else if self.time_when_penalized_clicked.is_none_or(|time| {
                     context
                         .cycle_time
                         .start_time

crates/control/src/ready_signal_detection_filter.rs

@@ -155,7 +155,7 @@ impl ReadySignalDetectionFilter {
             let now = context.cycle_time.start_time;
             self.detection_times[*context.player_number] = Some(now);
 
-            if self.last_time_message_sent.as_ref().map_or(true, |time| {
+            if self.last_time_message_sent.as_ref().is_none_or(|time| {
                 now.duration_since(*time).expect("Time ran backwards") >= *context.message_interval
             }) && context.remaining_amount_of_messages.is_some_and(
                 |remaining_amount_of_messages| {

crates/framework/src/perception_databases.rs

@@ -38,7 +38,7 @@ where
         self.first_timestamp_of_temporary_databases
     }
 
-    pub fn persistent(&self) -> Range<SystemTime, Databases> {
+    pub fn persistent(&'_ self) -> Range<'_, SystemTime, Databases> {
         if let Some(first_timestamp_of_temporary_databases) =
             self.first_timestamp_of_temporary_databases
         {
@@ -49,7 +49,7 @@ where
         }
     }
 
-    pub fn temporary(&self) -> Range<SystemTime, Databases> {
+    pub fn temporary(&'_ self) -> Range<'_, SystemTime, Databases> {
         if let Some(first_timestamp_of_temporary_databases) =
             self.first_timestamp_of_temporary_databases
         {

crates/hulk_imagine/src/write_to_mcap.rs

@@ -61,7 +61,7 @@ where
 
             outputs.into_iter().try_for_each(|(topic, data)| {
                 mcap_converter.add_to_mcap(
-                    format!("{}.{}", cycler_name, topic),
+                    format!("{cycler_name}.{topic}"),
                     &data,
                     index as u32,
                     timing.timestamp,

crates/hulk_replayer/src/ticks.rs

@@ -181,7 +181,7 @@ impl<'state> Ticks<'state> {
                     absolute_time_to_time_string(current.map_to_absolute_time(self.frame_range));
                 let galley = painter.layout_no_wrap(text.clone(), font.clone(), color_strong);
                 let text_position = pos2(x.inner() - galley.rect.width() / 2.0, clip_rect.top());
-                if position_text_rect.map_or(true, |position_text_rect| {
+                if position_text_rect.is_none_or(|position_text_rect| {
                     !galley
                         .rect
                         .translate(text_position.to_vec2())