Skip to content

Commit beee3b8

Browse files
authored
Merge pull request #5 from HackYourFuture/fix/assignment-schema-dev-name
fix(assignment): use existing dev_<name> schema, not dev_<name>_borough
2 parents bd36cac + 858e262 commit beee3b8

4 files changed

Lines changed: 5 additions & 5 deletions

File tree

.github/workflows/dbt-parse.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,6 @@ jobs:
3939
PG_DBNAME: postgres
4040
run: |
4141
cp profiles.yml.example profiles.yml
42-
sed -i 's/dev_<your_name>_borough/dev_ci_borough/' profiles.yml
42+
sed -i 's/dev_<your_name>/dev_ci/' profiles.yml
4343
dbt deps
4444
dbt parse

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ The project is already initialised, so Task 1 is just pointing it at the databas
4343

4444
```bash
4545
cp profiles.yml.example profiles.yml
46-
# edit profiles.yml: replace <your_name> so schema reads dev_<your_name>_borough
46+
# edit profiles.yml: replace <your_name> so schema reads dev_<your_name>
4747
```
4848

4949
2. Export the connection env vars (values are in the class vault; ask your mentor if you are missing them):

profiles.yml.example

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ nyc_taxi_borough_daily:
88
user: "{{ env_var('PG_USER') }}"
99
password: "{{ env_var('PG_PASSWORD') }}"
1010
dbname: "{{ env_var('PG_DBNAME', 'postgres') }}"
11-
schema: "dev_<your_name>_borough" # TODO: replace <your_name> with your first name
11+
schema: "dev_<your_name>" # TODO: replace <your_name> with your first name (the schema you already own)
1212
threads: 1
1313

1414
# Copy this file to profiles.yml (same directory), fill in your name, and ensure

reports/answers.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
# Business Question Answers
22

3-
Queries run against `dev_<your_name>_borough.fct_daily_borough_stats`.
3+
Queries run against `dev_<your_name>.fct_daily_borough_stats`.
44

5-
## Q1: Highest total `total_fare` across all of January 2024
5+
## Q1: Highest total `total_fare` across the whole loaded dataset
66

77
**SQL:**
88

0 commit comments

Comments
 (0)