Skip to content
This repository was archived by the owner on Mar 29, 2022. It is now read-only.
This repository was archived by the owner on Mar 29, 2022. It is now read-only.

Unclear wording around ineligible repositories #698

@boardfish

Description

@boardfish

Describe the bug
In the legend on the profile page, it's not explicitly stated whether merged PRs to repositories that haven't opted into Hacktoberfest count towards the quota.

Your PR was submitted to a repository that is not participating in Hacktoberfest. Maintainers of the repository can add the "hacktoberfest" topic to their repository if they wish to participate. Alternatively, an individual PR can be opted-in with a maintainer adding the "hacktoberfest-accepted" label to the PR.

I don't think it helps that the icon is different from Invalid PRs either, but I'm not sure how to address that.

Expected behavior
If PRs to repositories that haven't opted in do not count when they are merged without the hacktoberfest-accepted label, I'd suggest the following copy:

Your PR was submitted to a repository that is not participating in Hacktoberfest. Your PR won't count towards winning Hacktoberfest.
Maintainers of the repository...

As I'm writing this issue, I'm leaning towards this being the case, but the intent doesn't feel too explicit in the current copy.

If PRs to repositories that haven't opted in do count regardless of whether the label is applied, I'd suggest the following copy:

Your PR was submitted to a repository that is not participating in Hacktoberfest. However, your PR will count towards winning Hacktoberfest if it is merged.


I'm happy to take on this change if it makes sense to folks.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bug-reportUnverified user submitted bug that needs verification

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions