-
Notifications
You must be signed in to change notification settings - Fork 1
Open
Description
When we hit the 'DEL' key in the serial mode it is actually appended to the string rather than remove the last character.
This could be improved in this part of the code:
esp32-c3/lib/hack/taskSerial.cpp
Lines 25 to 34 in bd312cd
| if (inChar == 13 || inChar == 10) { | |
| // this is a carriage return; | |
| if (serialBufferPosition > 0) { | |
| printResult(serialBuffer, &Serial); | |
| } | |
| serialBufferPosition = 0; | |
| serialBuffer[0] = '\0'; | |
| } else { | |
| if (serialBufferPosition < SERIAL_BUFFER_LENGTH) { | |
| serialBuffer[serialBufferPosition] = inChar; |
Metadata
Metadata
Assignees
Labels
No labels