migrate to TypeScript only features

Author: Haehnchen

src/modules/services.ts

@@ -35,6 +35,8 @@ import { LogsRepository, TickerLogRepository, TickerRepository } from '../reposi
 import { QueueManager } from '../utils/queue';
 import { FileCache } from '../utils/file_cache';
 import { BinancePriceService } from '../utils/binance_price_service';
+import nodemailer from 'nodemailer';
+import { Telegraf } from 'telegraf';
 
 import { ExchangeCandleCombine } from './exchange/exchange_candle_combine';
 import { ExchangeInstanceService } from './system/exchange_instance_service';
@@ -429,11 +431,9 @@ const services: Services = {
   },
 
   createMailer: function (): any {
-    const mail = require('nodemailer');
-
     const config = this.getConfig();
 
-    return mail.createTransport({
+    return nodemailer.createTransport({
       host: config.notify?.mail?.server,
       port: config.notify?.mail?.port,
       secure: config.notify?.mail?.port == 465,
@@ -445,7 +445,6 @@ const services: Services = {
   },
 
   createTelegram: function (): any {
-    const { Telegraf } = require('telegraf');
     const config = this.getConfig();
     const { token } = config.notify?.telegram || {};
 

src/utils/indicators.ts

@@ -65,9 +65,9 @@ interface TalibModule {
   execute: (params: Record<string, unknown>) => TalibResult;
 }
 
-// Lazy load modules
+// Lazy load modules (using dynamic import for heavy native modules)
 const getTalib = (): TalibModule => require('talib');
-const getTechnicalIndicators = (): typeof import('technicalindicators') => require('technicalindicators');
+const getTechnicalIndicators = () => require('technicalindicators') as typeof import('technicalindicators');
 
 interface PivotPointsWithWicksResult {
   high?: { close?: number; high?: number };

src/utils/queue.ts

@@ -1,4 +1,4 @@
-const Queue = require('queue-promise');
+import Queue from 'queue-promise';
 
 export class QueueManager {
   private queue: any;

test/deploy.test.js test/deploy.test.tstest/deploy.test.js renamed to test/deploy.test.ts

@@ -1,5 +1,5 @@
-const assert = require('assert');
-const fs = require('fs');
+import assert from 'assert';
+import fs from 'fs';
 
 describe('#validate pre deployment files', function() {
   it('test that config.json.dist file is valid', () => {
@@ -12,6 +12,6 @@ describe('#validate pre deployment files', function() {
     const instances = require(`${__dirname}/../instance.js.dist`);
 
     assert.equal(instances.symbols.length > 0, true);
-    assert.equal(instances.symbols.filter(i => i.symbol === 'ETHUSD').length, 1);
+    assert.equal(instances.symbols.filter((i: any) => i.symbol === 'ETHUSD').length, 1);
   });
 });

test/storage/tickers.test.js test/storage/tickers.test.tstest/storage/tickers.test.js renamed to test/storage/tickers.test.ts

@@ -1,7 +1,7 @@
-const assert = require('assert');
-const moment = require('moment');
-const { Tickers } = require('../../src/storage/tickers');
-const { Ticker } = require('../../src/dict/ticker');
+import assert from 'assert';
+import moment from 'moment';
+import { Tickers } from '../../src/storage/tickers';
+import { Ticker } from '../../src/dict/ticker';
 
 describe('#tickers', function() {
   it('test getting update tickers', () => {
@@ -13,9 +13,9 @@ describe('#tickers', function() {
       .subtract(5000, 'ms')
       .toDate();
 
-    assert.equal(tickers.get('foobar', 'BTCUSD').ask, 1338);
+    assert.equal(tickers.get('foobar', 'BTCUSD')?.ask, 1338);
     assert.equal(tickers.getIfUpToDate('foobar', 'BTCUSD', 1000), undefined);
 
-    assert.equal(tickers.getIfUpToDate('foobar', 'BTCUSD', 7000).ask, 1338);
+    assert.equal(tickers.getIfUpToDate('foobar', 'BTCUSD', 7000)?.ask, 1338);
   });
 });

test/system/config_service.test.js test/system/config_service.test.tstest/system/config_service.test.js renamed to test/system/config_service.test.ts

@@ -1,7 +1,7 @@
-const assert = require('assert');
-const fs = require('fs');
-const path = require('path');
-const { ConfigService } = require('../../src/modules/system/config_service');
+import assert from 'assert';
+import fs from 'fs';
+import path from 'path';
+import { ConfigService } from '../../src/modules/system/config_service';
 
 describe('#config service test', function() {
   const testConfigDir = path.join(__dirname, 'fixtures');