Skip to content

Commit 34e20dd

Browse files
committed
Removed initial console appender
1 parent a729b10 commit 34e20dd

3 files changed

Lines changed: 1 addition & 17 deletions

File tree

src/main/java/nl/altindag/log/LogCaptor.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,6 @@ public final class LogCaptor implements AutoCloseable {
5757
private LogCaptor(String loggerName) {
5858
logger = LogbackUtils.getLogger(loggerName);
5959
inMemoryAppender = AppenderUtils.configureInMemoryAppender(logger, eventsCollector);
60-
consoleAppender = AppenderUtils.configureConsoleAppender(logger);
6160

6261
JavaUtilLoggingLoggerUtils.redirectToSlf4j(loggerName);
6362
logLevelContainer.putIfAbsent(logger.getName(), logger.getEffectiveLevel());

src/main/java/nl/altindag/log/util/AppenderUtils.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -80,10 +80,6 @@ public static InMemoryAppender<ILoggingEvent> configureInMemoryAppender(Logger l
8080
return inMemoryAppender;
8181
}
8282

83-
public static ConsoleAppender<ILoggingEvent> configureConsoleAppender(Logger logger) {
84-
return configureConsoleAppender(logger, null);
85-
}
86-
8783
public static ConsoleAppender<ILoggingEvent> configureConsoleAppender(Logger logger, ConsoleAppender<ILoggingEvent> appender) {
8884
String loggerName = logger.getName();
8985
ConsoleAppender<ILoggingEvent> consoleAppender = createConsoleAppender(logger, appender);

src/test/java/nl/altindag/log/LogCaptorShould.java

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -727,12 +727,6 @@ void notProvideConsoleAppenderWhenNopStatusListenerIsPresentAsLogBackConfigurati
727727
new BasicConfigurator().configure(loggerContext); // Reset to default configuration logback configuration.
728728
}
729729

730-
@Test
731-
void provideConsoleAppenderWhenNoNopStatusListenerIsPresentAsLogBackConfiguration() {
732-
logCaptor = LogCaptor.forClass(ServiceWithApacheLog4j.class);
733-
assertThat(AppenderUtils.getConsoleAppender(logCaptor.getLogger())).isNotEmpty();
734-
}
735-
736730
@Test
737731
void provideConsoleAppenderWhenNoNopStatusListenerIsPresentAsLogBackConfigurationForRootLogCaptor() {
738732
logCaptor = LogCaptor.forRoot();
@@ -761,16 +755,11 @@ void disableConsoleOutput() {
761755

762756
private static void assertListAppender(Logger logger) {
763757
List<Appender<?>> appenders = fetchAppenders(logger);
764-
assertThat(appenders).hasSize(2);
758+
assertThat(appenders).hasSize(1);
765759
assertThat(appenders.get(0))
766760
.isInstanceOf(InMemoryAppender.class)
767761
.extracting(Appender::getName)
768762
.isEqualTo("logcaptor-in-memory-appender");
769-
770-
assertThat(appenders.get(1))
771-
.isInstanceOf(ConsoleAppender.class)
772-
.extracting(Appender::getName)
773-
.isEqualTo("console");
774763
}
775764

776765
private static List<Appender<?>> fetchAppenders(Logger logger) {

0 commit comments

Comments
 (0)