Skip to content

Commit 599ef8b

Browse files
committed
Removed Akka Client as it is hosted on a private repo which requires a token
1 parent f32fc11 commit 599ef8b

9 files changed

Lines changed: 1 addition & 223 deletions

File tree

README.MD

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -409,7 +409,7 @@ All client examples use the same base ssl configuration created within the [SSLC
409409
**Scala**
410410
* [Twitter Finagle](https://github.com/twitter/finagle) -> [Client Configuration & Example request](https://github.com/Hakky54/mutual-tls-ssl/blob/master/client/src/main/java/nl/altindag/client/service/FinagleHttpClientService.scala)
411411
* [Twitter Finagle Featherbed](https://github.com/finagle/featherbed) -> [Client Configuration & Example request](https://github.com/Hakky54/mutual-tls-ssl/blob/d78e4e81b8b775d3ff09c11b0a7c1532a741199e/client/src/main/java/nl/altindag/client/service/FeatherbedRequestService.scala#L19)
412-
* [Akka Http Client](https://github.com/akka/akka-http) -> [Client Configuration](https://github.com/Hakky54/mutual-tls-ssl/blob/35cba2f3a2dcd73b01fa323b99eec7777f7429bb/client/src/main/java/nl/altindag/client/ClientConfig.java#L253) | [Example request](https://github.com/Hakky54/mutual-tls-ssl/blob/master/client/src/main/java/nl/altindag/client/service/AkkaHttpClientService.java)
412+
* [Akka Http Client](https://github.com/akka/akka-http) -> [Client Configuration](https://github.com/Hakky54/mutual-tls-ssl/blob/35cba2f3a2dcd73b01fa323b99eec7777f7429bb/client/src/main/java/nl/altindag/client/ClientConfig.java#L253) | [Example request](https://github.com/Hakky54/mutual-tls-ssl/blob/f32fc11ac1bf879fe5f9ba55a57a4e8188eb29e3/client/src/main/java/nl/altindag/client/service/AkkaHttpClientService.java#L34)
413413
* [Dispatch Reboot](https://github.com/dispatch/reboot) -> [Client Configuration & Example request](https://github.com/Hakky54/mutual-tls-ssl/blob/master/client/src/main/java/nl/altindag/client/service/DispatchRebootService.scala)
414414
* [ScalaJ / Simplified Http Client](https://github.com/scalaj/scalaj-http) -> [Client Configuration & Example request](https://github.com/Hakky54/mutual-tls-ssl/blob/master/client/src/main/java/nl/altindag/client/service/ScalaJHttpClientService.scala)
415415
* [Sttp](https://github.com/softwaremill/sttp) -> [Client Configuration & Example request](https://github.com/Hakky54/mutual-tls-ssl/blob/master/client/src/main/java/nl/altindag/client/service/SttpHttpClientService.scala)

client/pom.xml

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -86,14 +86,6 @@
8686
<groupId>com.fasterxml.jackson.module</groupId>
8787
<artifactId>jackson-module-scala_${version.scala}</artifactId>
8888
</dependency>
89-
<dependency>
90-
<groupId>com.typesafe.akka</groupId>
91-
<artifactId>akka-http_${version.scala}</artifactId>
92-
</dependency>
93-
<dependency>
94-
<groupId>com.typesafe.akka</groupId>
95-
<artifactId>akka-stream_${version.scala}</artifactId>
96-
</dependency>
9789
<dependency>
9890
<groupId>org.dispatchhttp</groupId>
9991
<artifactId>dispatch-core_${version.scala}</artifactId>
@@ -503,11 +495,6 @@
503495
<mainClass>${main-class-client}</mainClass>
504496
</transformer>
505497

506-
<!-- required adding the reference.conf file for akka client -->
507-
<transformer implementation="org.apache.maven.plugins.shade.resource.AppendingTransformer">
508-
<resource>reference.conf</resource>
509-
</transformer>
510-
511498
<!-- required adding the bus-extensions.txt file for apache cxf client -->
512499
<transformer implementation="org.apache.maven.plugins.shade.resource.AppendingTransformer">
513500
<resource>META-INF/cxf/bus-extensions.txt</resource>

client/src/main/java/nl/altindag/client/ClientConfig.java

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -15,15 +15,12 @@
1515
*/
1616
package nl.altindag.client;
1717

18-
import akka.actor.ActorSystem;
19-
import akka.http.javadsl.ConnectionContext;
2018
import com.github.mizosoft.methanol.Methanol;
2119
import com.google.api.client.http.HttpTransport;
2220
import com.google.api.client.http.javanet.NetHttpTransport;
2321
import com.google.gson.GsonBuilder;
2422
import com.sun.jersey.api.client.config.DefaultClientConfig;
2523
import com.sun.jersey.client.urlconnection.HTTPSProperties;
26-
import com.typesafe.config.ConfigFactory;
2724
import feign.Feign;
2825
import feign.googlehttpclient.GoogleHttpClient;
2926
import feign.hc5.ApacheHttp5Client;
@@ -237,23 +234,6 @@ public Retrofit retrofit(@Qualifier("okHttpClient") OkHttpClient okHttpClient) {
237234
.build();
238235
}
239236

240-
@Bean
241-
public ActorSystem actorSystem() {
242-
return ActorSystem.create(
243-
ClientConfig.class.getSimpleName(),
244-
ConfigFactory.defaultApplication(ClientConfig.class.getClassLoader())
245-
);
246-
}
247-
248-
@Bean
249-
public akka.http.javadsl.Http akkaHttpClient(SSLFactory sslFactory,
250-
ActorSystem actorSystem) {
251-
var http = akka.http.javadsl.Http.get(actorSystem);
252-
var httpsContext = ConnectionContext.httpsClient(sslFactory.getSslContext());
253-
http.setDefaultClientHttpsContext(httpsContext);
254-
return http;
255-
}
256-
257237
@Bean
258238
public AsyncHttpClient asyncHttpClient(SSLFactory sslFactory) throws SSLException {
259239
var sslContext = NettySslUtils.forClient(sslFactory).build();

client/src/main/java/nl/altindag/client/ClientType.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@ public enum ClientType {
3535
UNIREST("unirest"),
3636
RETROFIT("retrofit"),
3737
FINAGLE("finagle"),
38-
AKKA_HTTP_CLIENT("akka httpclient"),
3938
DISPATCH_REBOOT_HTTP_CLIENT("dispatch reboot httpclient"),
4039
ASYNC_HTTP_CLIENT("async httpclient"),
4140
SCALAJ_HTTP_CLIENT("scalaj httpclient"),

client/src/main/java/nl/altindag/client/service/AkkaHttpClientService.java

Lines changed: 0 additions & 67 deletions
This file was deleted.

client/src/test/java/nl/altindag/client/ClientConfigShould.java

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,6 @@
1515
*/
1616
package nl.altindag.client;
1717

18-
import akka.actor.ActorSystem;
19-
import akka.http.javadsl.Http;
2018
import com.github.mizosoft.methanol.Methanol;
2119
import com.google.api.client.http.HttpTransport;
2220
import feign.Feign;
@@ -304,24 +302,6 @@ void createRetrofitWithProvidedOkHttpClient() {
304302
assertThat(retrofit.converterFactories()).has(GSON_CONVERTER_FACTORY);
305303
}
306304

307-
@Test
308-
void createAkkaHttpClient() {
309-
SSLFactory sslFactory = createSSLFactory(false, true);
310-
311-
Http http = victim.akkaHttpClient(sslFactory, ActorSystem.create());
312-
313-
assertThat(http).isNotNull();
314-
verify(sslFactory, times(1)).getSslContext();
315-
}
316-
317-
@Test
318-
void createActorSystem() {
319-
ActorSystem actorSystem = victim.actorSystem();
320-
321-
assertThat(actorSystem).isNotNull();
322-
assertThat(actorSystem.name()).isEqualTo("ClientConfig");
323-
}
324-
325305
@Test
326306
void createAsyncHttpClient() throws SSLException {
327307
SSLFactory sslFactory = createSSLFactory(true, false);

client/src/test/java/nl/altindag/client/service/AkkaHttpClientServiceShould.java

Lines changed: 0 additions & 77 deletions
This file was deleted.

client/src/test/resources/features/Hello.feature

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ Feature: Securing the connection between you and the world
1010

1111
Examples:
1212
| client |
13-
| Akka HttpClient |
1413
| Apache HttpClient |
1514
| Apache Http Async Client |
1615
| Apache 5 Http Client |

pom.xml

Lines changed: 0 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -45,9 +45,6 @@
4545
<version.unirest>3.14.5</version.unirest>
4646
<version.retrofit>3.0.0</version.retrofit>
4747
<version.finagle>24.2.0</version.finagle>
48-
<version.akka-http>10.7.1</version.akka-http>
49-
<version.akka-stream>2.10.7</version.akka-stream>
50-
<version.akka-pki>2.10.7</version.akka-pki>
5148
<version.dispatch-core>2.0.0</version.dispatch-core>
5249
<version.scalaj-http>2.4.2</version.scalaj-http>
5350
<version.async-http-client>3.0.2</version.async-http-client>
@@ -213,21 +210,6 @@
213210
<artifactId>okhttp</artifactId>
214211
<version>${version.okhttp}</version>
215212
</dependency>
216-
<dependency>
217-
<groupId>com.typesafe.akka</groupId>
218-
<artifactId>akka-http_${version.scala}</artifactId>
219-
<version>${version.akka-http}</version>
220-
</dependency>
221-
<dependency>
222-
<groupId>com.typesafe.akka</groupId>
223-
<artifactId>akka-stream_${version.scala}</artifactId>
224-
<version>${version.akka-stream}</version>
225-
</dependency>
226-
<dependency>
227-
<groupId>com.typesafe.akka</groupId>
228-
<artifactId>akka-pki_${version.scala}</artifactId>
229-
<version>${version.akka-pki}</version>
230-
</dependency>
231213
<dependency>
232214
<groupId>org.dispatchhttp</groupId>
233215
<artifactId>dispatch-core_${version.scala}</artifactId>
@@ -1104,11 +1086,6 @@ limitations under the License.
11041086
<enabled>false</enabled>
11051087
</snapshots>
11061088
</repository>
1107-
<repository>
1108-
<id>akka-repository</id>
1109-
<name>Akka library repository</name>
1110-
<url>https://repo.akka.io/maven</url>
1111-
</repository>
11121089
</repositories>
11131090

11141091
<licenses>

0 commit comments

Comments
 (0)