Fix codacy issues

Author: Hamza Ghazouani

Example/HGPlaceholders/AppDelegate/AppDelegate.swift

@@ -40,6 +40,4 @@ class AppDelegate: UIResponder, UIApplicationDelegate {
         // Called when the application is about to terminate. Save data if appropriate. See also applicationDidEnterBackground:.
     }
 
-
 }
-

Example/HGPlaceholders/CollectionViewExample/CollectionViewController.swift

@@ -14,7 +14,7 @@ private let reuseIdentifier = "Cell"
 class CollectionViewController: UICollectionViewController, UICollectionViewDelegateFlowLayout {
 
     var placeholderCollectionView: CollectionView? {
-        get { return collectionView as? CollectionView }
+        return collectionView as? CollectionView
     }
 
     var data = [
@@ -119,6 +119,7 @@ class CollectionViewController: UICollectionViewController, UICollectionViewDele
 }
 
 extension CollectionViewController: PlaceholderDelegate {
+    
     func view(_ view: Any, actionButtonTappedFor placeholder: Placeholder) {
         (view as? CollectionView)?.showDefault()
     }

Example/HGPlaceholders/TableViewExample/TableViewController.swift

@@ -99,6 +99,7 @@ class ViewController: UITableViewController {
 
         present(alertController, animated: true, completion: nil)
     }
+    
 }
 
 extension ViewController: PlaceholderDelegate {

HGPlaceholders/Classes/Placeholder/PlaceholderKey.swift

@@ -43,16 +43,20 @@ public struct PlaceholderKey: Hashable {
     public static var noResultsKey = PlaceholderKey(value: "noResults")
 
     /// Is used to add new keys
-    public static func custom(key: String) -> PlaceholderKey { return PlaceholderKey(value: key) }
+    public static func custom(key: String) -> PlaceholderKey {
+        return PlaceholderKey(value: key)
+    }
 
     public var hashValue: Int {
         return value.hashValue
     }
 }
 
 extension PlaceholderKey: Equatable {
+    
     /// To make PlaceholderKey hashable 
     public static func == (lhs: PlaceholderKey, rhs: PlaceholderKey) -> Bool {
         return lhs.value == rhs.value
     }
+    
 }

HGPlaceholders/Classes/PlaceholdersProvider/PlaceholderDataSourceDelegate.swift

@@ -36,7 +36,7 @@ class PlaceholderDataSourceDelegate: NSObject {
     ///   - tintColor: the tint color to apply
     func fill(cell: CellPlaceholding, to placeholder: Placeholder, tintColor: UIColor?) {
 
-        /** if the the placeholder created by xib and data/style are nil, we should keep the xib data/style **/
+        /* if the the placeholder created by xib and data/style are nil, we should keep the xib data/style */
 
         // apply style
         if let style = placeholder.style {
@@ -85,6 +85,7 @@ class PlaceholderDataSourceDelegate: NSObject {
         }
         return height
     }
+    
 }
 
 // MARK: table view data source methods
@@ -110,7 +111,7 @@ extension PlaceholderDataSourceDelegate: UITableViewDataSource {
 
         cell.selectionStyle = .none
         // If the cell does not inherit from PlaceholderTableViewCell, the data and the style can't be applied
-        guard let placeholderTableViewCell = (cell as? PlaceholderTableViewCell) else {
+        guard let placeholderTableViewCell = cell as? PlaceholderTableViewCell else {
             return cell
         }
 
@@ -157,7 +158,10 @@ extension PlaceholderDataSourceDelegate: UITableViewDelegate {
     // animate the cell
     func tableView(_ tableView: UITableView, willDisplay cell: UITableViewCell, forRowAt indexPath: IndexPath) {
 
-        if placeholder.style?.isAnimated == false { return }
+        if placeholder.style?.isAnimated == false {
+            return
+        }
+        
         guard let placeholderTableViewCell = cell as? PlaceholderTableViewCell else { return }
         animate(cell: placeholderTableViewCell)
     }
@@ -177,15 +181,15 @@ extension PlaceholderDataSourceDelegate: UICollectionViewDataSource {
         let cell = collectionView.dequeueReusableCell(withReuseIdentifier: reuseIdentifier, for: indexPath)
 
         // If the cell does not inherit from PlaceholderTableViewCell, the data and the style can't be applied
-        guard let placeholderCollectionViewCell = (cell as? PlaceholderCollectionViewCell) else {
+        guard let placeholderCollectionViewCell = cell as? PlaceholderCollectionViewCell else {
             return cell
         }
 
         fill(cell: placeholderCollectionViewCell, to: placeholder, tintColor: collectionView.tintColor)
 
         // forward action to placeholder delegate
         placeholderCollectionViewCell.onActionButtonTap = { [unowned self] in
-            guard let placeholderCollectionView = (collectionView as? CollectionView) else { return }
+            guard let placeholderCollectionView = collectionView as? CollectionView else { return }
             placeholderCollectionView.placeholderDelegate?.view(collectionView, actionButtonTappedFor: self.placeholder)
         }
         return cell

HGPlaceholders/Classes/PlaceholdersProvider/PlaceholdersProvider.swift

@@ -70,25 +70,25 @@ final public class PlaceholdersProvider {
 
     /// Returns an instance of PlaceholderDataSourceDelegate of default loading key
     /// - Returns: returns PlaceholderDataSourceDelegate instance, nil of no placeholder found with this key
-    func loadingDataSource() -> PlaceholderDataSourceDelegate?  {
+    func loadingDataSource() -> PlaceholderDataSourceDelegate? {
         return dataSourceAndDelegate(with: .loadingKey)
     }
 
     /// Returns an instance of PlaceholderDataSourceDelegate of default error key
     /// - Returns: returns PlaceholderDataSourceDelegate instance, nil of no placeholder found with this key
-    func errorDataSource() -> PlaceholderDataSourceDelegate?  {
+    func errorDataSource() -> PlaceholderDataSourceDelegate? {
         return dataSourceAndDelegate(with: .errorKey)!
     }
 
     /// Returns an instance of PlaceholderDataSourceDelegate of default no results key
     /// - Returns: returns PlaceholderDataSourceDelegate instance, nil of no placeholder found with this key
-    func noResultsDataSource() -> PlaceholderDataSourceDelegate?  {
+    func noResultsDataSource() -> PlaceholderDataSourceDelegate? {
         return dataSourceAndDelegate(with: .noResultsKey)!
     }
 
     /// Returns an instance of PlaceholderDataSourceDelegate of default no connection key
     /// - Returns: returns PlaceholderDataSourceDelegate instance, nil of no placeholder found with this key
-    func noConnectionDataSource() -> PlaceholderDataSourceDelegate?  {
+    func noConnectionDataSource() -> PlaceholderDataSourceDelegate? {
         return dataSourceAndDelegate(with: .noConnectionKey)
     }
 }

HGPlaceholders/Classes/Protocols/NibLoadable.swift

@@ -10,11 +10,12 @@ import UIKit
 
 // MARK: Protocol Definition
 
-/// Make your UIView subclasses conform to this protocol when:
-///  * they *are* NIB-based, and
-///  * this class is used as the XIB's root view
-///
-/// to be able to instantiate them from the NIB in a type-safe manner
+/** Make your UIView subclasses conform to this protocol when:
+ * they *are* NIB-based, and
+ * this class is used as the XIB's root view
+ *
+ * to be able to instantiate them from the NIB in a type-safe manner
+ */
 protocol NibLoadable: class {
     /// The nib file to use to load a new instance of the View designed in a XIB
     static var nib: UINib { get }
@@ -23,8 +24,8 @@ protocol NibLoadable: class {
 // MARK: Default implementation
 
 extension NibLoadable {
-    /// By default, use the nib which have the same name as the name of the class,
-    /// and located in the bundle of that class
+    /* By default, use the nib which have the same name as the name of the class,
+         and located in the bundle of that class */
     static var nib: UINib {
         return UINib(nibName: String(describing: self), bundle: Bundle(for: self))
     }

HGPlaceholders/Classes/Views/CollectionView.swift

@@ -19,7 +19,9 @@ open class CollectionView: UICollectionView {
      */
     open override var collectionViewLayout: UICollectionViewLayout {
         didSet {
-            if collectionViewLayout === placeholderLayout { return }
+            if collectionViewLayout === placeholderLayout {
+                return
+            }
             defaultLayout = collectionViewLayout
         }
     }
@@ -57,7 +59,9 @@ open class CollectionView: UICollectionView {
     open override weak var delegate: UICollectionViewDelegate? {
         didSet {
             /* we save only the initial delegate (and not the placeholder delegate) to allow to go back to the initial one */
-            if  delegate is PlaceholderDataSourceDelegate { return }
+            if  delegate is PlaceholderDataSourceDelegate {
+                return
+            }
             defaultDelegate = delegate
         }
     }

HGPlaceholders/Classes/Views/TableView+Switcher.swift

@@ -54,4 +54,5 @@ extension TableView: PlaceholdersSwitcher {
     public func showDefault() {
         self.switchTo(dataSource: defaultDataSource, delegate: defaultDelegate)
     }
+    
 }

HGPlaceholders/Classes/Views/TableView.swift

@@ -46,7 +46,9 @@ open class TableView: UITableView {
     weak open override var dataSource: UITableViewDataSource? {
         didSet {
             /* we save only the initial data source (and not a placeholder datasource) to allow to go back to the initial data */
-            if  dataSource is PlaceholderDataSourceDelegate { return }
+            if  dataSource is PlaceholderDataSourceDelegate {
+                return
+            }
             defaultDataSource = dataSource
         }
     }
@@ -58,7 +60,9 @@ open class TableView: UITableView {
     open override weak var delegate: UITableViewDelegate? {
         didSet {
             /* we save only the initial delegate (and not the placeholder delegate) to allow to go back to the initial one */
-            if  delegate is PlaceholderDataSourceDelegate { return }
+            if  delegate is PlaceholderDataSourceDelegate {
+                return
+            }
             defaultDelegate = delegate
         }
     }
@@ -69,7 +73,9 @@ open class TableView: UITableView {
      */
     open override var tableHeaderView: UIView? {
         didSet {
-            if tableHeaderView == nil { return }
+            if tableHeaderView == nil {
+                return
+            }
 
             defaultTableHeaderView = tableHeaderView
         }