Decrease LockTimeout time for sp_getapplock

odinserj · odinserj · commit 9cc7d8f3c98c · 2024-11-08T17:31:07.000+07:00
This will cause slightly more queries, but will keep less worker threads in SQL Server blocked when attempting to acquire an already taken distributed lock.
diff --git a/src/Hangfire.SqlServer/SqlServerDistributedLock.cs b/src/Hangfire.SqlServer/SqlServerDistributedLock.cs
@@ -28,7 +28,7 @@ namespace Hangfire.SqlServer
 {
     public class SqlServerDistributedLock : IDisposable
     {
-        private static readonly TimeSpan LockTimeout = TimeSpan.FromSeconds(5);
+        private static readonly TimeSpan LockTimeout = TimeSpan.FromSeconds(1);
 
         private const string LockMode = "Exclusive";
         private const string LockOwner = "Session";
@@ -191,7 +191,7 @@ internal static void Acquire(DbConnection connection, string resource, TimeSpan
 
             do
             {
-                var command = connection
+                using var command = connection
                     .Create("sp_getapplock", CommandType.StoredProcedure, timeout: (int)(lockTimeout / 1000) + 5)
                     .AddParameter("@Resource", resource, DbType.String, size: 255)
                     .AddParameter("@DbPrincipal", "public", DbType.String, size: 32)

Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ namespace Hangfire.SqlServer`
`28`	`28`	`{`
`29`	`29`	`public class SqlServerDistributedLock : IDisposable`
`30`	`30`	`{`
`31`		`- private static readonly TimeSpan LockTimeout = TimeSpan.FromSeconds(5);`
	`31`	`+ private static readonly TimeSpan LockTimeout = TimeSpan.FromSeconds(1);`
`32`	`32`
`33`	`33`	`private const string LockMode = "Exclusive";`
`34`	`34`	`private const string LockOwner = "Session";`
`@@ -191,7 +191,7 @@ internal static void Acquire(DbConnection connection, string resource, TimeSpan`
`191`	`191`
`192`	`192`	`do`
`193`	`193`	`{`
`194`		`- var command = connection`
	`194`	`+ using var command = connection`
`195`	`195`	`.Create("sp_getapplock", CommandType.StoredProcedure, timeout: (int)(lockTimeout / 1000) + 5)`
`196`	`196`	`.AddParameter("@Resource", resource, DbType.String, size: 255)`
`197`	`197`	`.AddParameter("@DbPrincipal", "public", DbType.String, size: 32)`