Ensure ToStringWithOriginalStackTrace works regardless of PreserveOriginalStackTrace

odinserj · odinserj · commit f99227a38ccc · 2024-11-22T16:04:08.000+07:00
diff --git a/src/Hangfire.Core/Common/ShallowExceptionHelper.cs b/src/Hangfire.Core/Common/ShallowExceptionHelper.cs
@@ -36,11 +36,6 @@ public static string ToStringWithOriginalStackTrace([NotNull] this Exception exc
         {
             if (exception == null) throw new ArgumentNullException(nameof(exception));
 
-            if (!exception.Data.Contains(DataKey))
-            {
-                return GetFirstLines(exception.ToString(), numLines);
-            }
-
             return GetFirstLines(ToStringHelper(exception, false), numLines);
         }
 

Original file line number	Diff line number	Diff line change
`@@ -36,11 +36,6 @@ public static string ToStringWithOriginalStackTrace([NotNull] this Exception exc`
`36`	`36`	`{`
`37`	`37`	`if (exception == null) throw new ArgumentNullException(nameof(exception));`
`38`	`38`
`39`		`- if (!exception.Data.Contains(DataKey))`
`40`		`- {`
`41`		`- return GetFirstLines(exception.ToString(), numLines);`
`42`		`- }`
`43`		`-`
`44`	`39`	`return GetFirstLines(ToStringHelper(exception, false), numLines);`
`45`	`40`	`}`
`46`	`41`