Skip to content

getHandler 的一点疑问 #16

@limingxinleo

Description

@limingxinleo

Http 那里,我感觉有点问题

以下这个方法,如果存在 $default['handler'] 的话,感觉不应该当成一个 middleware push 进来,而是直接使用 setHandler 吧

    protected function getHandler()
    {
        $stack = HandlerStack::create();

        foreach ($this->middlewares as $middleware) {
            $stack->push($middleware);
        }

        if (isset(static::$defaults['handler']) && is_callable(static::$defaults['handler'])) {
            $stack->push(static::$defaults['handler'], self::USER_DEFINED_HANDLER);
        }

        if (isset($this->app['guzzle_handler'])) {
            $guzzleHandler = $this->app['guzzle_handler'];
            $stack->setHandler(is_string($guzzleHandler) ? new $guzzleHandler() : $this->app['guzzle_handler']);
        }

        return $stack;
    }

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions