[Feature Request] Key and Fairy Shuffle Toggle

[IntrinsicNerd]

Both keysanity (small and boss) and fairy shuffle are fairly advanced options, especially for less experienced rando players. I can only imagine most people who are at the level of playing glitchless logic are also likely playing at a level of not wanting small keys shuffled at the very least, as it adds a lot of complexity to a seed inherently. A similar issue can arise with fairies, as an important item locked behind a Great Fairy could add an incredible amount of time to a seed, especially for a newer player. These features shouldn't even be the default options, let alone the only options to play rando. It's an egregious enough omission that I almost put this under 'issues', but decided against it as to not start problems, and feature requests have been asked to be placed here. This is an issue, however, just not a bug. The obligation to play any of these shuffles would be enough for me personally to take issue with it, but for all of them to be obligatory to run randomizer was an incredible oversight at best, and a critical lapse in judgement and decision making skills at worst. The option to bind keys and fairies to their dungeons needs to be added as soon as possible, or else the 2ship rando will be the worst way to play rando for most casual players, even with every other QOL change added.

[garrettjoecox]

but for all of them to be obligatory to run randomizer was an incredible oversight at best, and a critical lapse in judgement and decision making skills at worst

Being the one at fault here, just to give you some context, the randomizer logic was written from scratch, with no prior experience doing this type of thing, so "pools" of items and checks with the types of limitations you are talking about is just fundamentally missing from the logic definitions & loop, it wasn't so much of an oversight as it was a "welp I know we are going to want this eventually but I literally have no idea how to do it so I'm moving past it". This was not the only instance of typical features missing, but as a result of not getting hung up on these features we have a mostly functional rando people can enjoy.

I do invite anyone to take a stab at this desired functionality though, I'd also be using it on my play throughs, I just don't have the capacity to figure it out at the moment.
https://github.com/HarbourMasters/2ship2harkinian/blob/develop/mm/2s2h/Rando/Logic/GlitchlessLogic.cpp

[IntrinsicNerd]

I appreciate the response. I should also clarify that I'm not mad at you by any means; I'm just passionate about things that don't matter and incredibly over dramatic. I do appreciate all the work you did on the logic, as I've looked through a lot of randomizer logic code before and it can get a little confusing to say the least (especially not being the one who writes it). I am by no means a C++ programmer, but I recently started learning so maybe I'll take a stab at it.

[rockmasterflex69]

The fairies problem is probably best solved by the whole slider to control # fairies you need thing.

I don't think the small keys are actually that much of a challenge here: for starters the first 2 entire dungeons can basically be fully cleared without ever opening a key-locked door.

Secondly, retreading areas multiple times to unlock something new is the core experience of a randomizer. I will admit that having a hard time finding the BOSS keys is absolutely frustrating, because you may need to clear an entire dungeon (somewhat time consuming... especially if it were STT or GBT) only to realize you're gonna have to retread in again to reclear it -

but this is MM. every dungeon has shortcuts to get to the boss room faster and more easily once you have items from later in the game. If anything keys being random in this game is so so much easier to deal with than keys in OOT.

itd be different if there were more dungeons, or even keys in totality. There's only 4! And the number of keys is actually really small

[IntrinsicNerd]

It's still about comfortably for players. Even if we discount the points about it adding a level of complexity that especially beginners and casuals may have an issue with, it doesn't change the fact that both of these shuffles are generally considered more advanced, and some players simply just don't like them much. The issue with stray fairies isn't just that you have 15 small checks to maybe get 1 important one, but it also adds 15 more small checks to each dungeon, and if the fairy fountains are junk, adds 60 extra junk checks all over the world. So while the great fairy count slider is nice, it doesn't change the core of the issue. Similarly with keys, just because you don't need all keys to beat a dungeon doesn't mean you may not need all keys in a dungeon to beat the seed. If something important is behind a locked dungeon door, I have to find that key. If I know the keys are in the dungeon, I know I can full clear it (at least theoretically), which is a level of comfort that is once again nice for more casual players, but also a way to once again make seeds less complex for people who want that. In fact, all three of those options together would be very nice for casual races and players, since you could set all keys and fairies to their respective dungeons, and if you wanted you could even make it so you don't have to get all the fairies so that a "full clear" is even easier.

[Caladius]

I don't think anyone really has any issues with the feature being added or not, nor needs reasons why or why not to add it.

Someone with time, energy, and interest needs to come along and make a PR.