Achievements are shown even if they are disabled

[vanfanel]

• I have checked the known issues and searched Github to ensure this issue has not already been reported.
• This is not a feature request, I know those belong on Discord/Github Discussions.

Description of the bug:

Even if Achievements are disabled, they pop-up while playing and are tracked.

Can you reproduce? If so please list the steps:

• No, I cannot reproduce this bug
• Yes, here are the steps to reproduce the bug:

1. Build the engine from latest GIT sources
2. Start playing
3. Disable Achievements
4. Play the game to see achievements popping up and being tracked even if they are disabled.

Expected behavior:

Achievements shouldn't pop-up or register if disabled.

Screenshots or videos:

System Information:

• OS: GNU/Linux
• GFX Backend: OpenGL
• Game Version: USA
• Rom Version: 1.0

[vanfanel]

This only happens when continuing a game saved with a previous version of the engine: starting a new game, if achievements are disabled they don't pop-up or register.

[vanfanel]

A workaround is manually editing the save game's JSON and setting "achievements": false.

So, the underlying problem is that the saves from previous versions of the engine don't get their achievements field updated when opened with current version of the engine + achievements disabled.