Options menu revamp pt 2

[briankchan]

desktop:

• tabs or collapsible sections?
  • most useful things will fit under General, as they do now.

mobile:

• tabs with horizontal swiping to switch (jquery mobile) or collapsible sections
• rewrite to improve stability while zooming
  • stop relying on silly padding/positioning interactions
  • probably scrap the animation and just go with a static button that brings up a full-screen menu.)
• should be able to use media queries instead of the current isMobile() method

[mananshah99]

👍 will get started asap

[briankchan]

btw are you working on the dev branch or gh-pages? I'm still not at all satisfied with the state of the code on dev, but also don't at all have the time to fix it.
Also I should probably update the readme sometime to reflect the node.js stuff

[mananshah99]

Was planning on working on dev- the node.js stuff isnt perfect but its good
enough. When do you want to merge the two branches? I can fix up some minor
node details but a total refractor might have to wait until winter break-ish

On Sun, Oct 26, 2014 at 3:11 PM, iluvredwall notifications@github.com
wrote:

btw are you working on the dev branch or gh-pages? I'm still not at all
satisfied with the state of the code on dev, but also don't at all have the
time to fix it.
Also I should probably update the readme sometime to reflect the node.js
stuff

—
Reply to this email directly or view it on GitHub
#22 (comment)
.

Manan

"Stay hungry, stay foolish" - Steve Jobs

[briankchan]

It should be fine to merge anytime - all the code works and everything (afaik) - I just never bothered because i wasn't sure when I'd stop working on it (I didn't really want to be merging into gh-pages all the time), and I haven't had the time since I stopped.

I think there two major things I wanted to work on as far as refactoring goes:

• splitting the schedule creation/highlighting into more, shorter methods for readability (and just generally cleaning up that part of the code)
• having the options module save user options into the relevant modules to make option loading/saving cleaner
  ** also, putting option-specific actions into functions in optionsObject so that the options module is completely isolated from optionsObject (i.e. adding a new option will basically never require editing options.js; options.js could work as a completely separate framework.)

Basically the the first bit is readability and the second bit is all just making the code more object-oriented. Both of these could be improved in more than just these two places, but I'm pretty sure that's where each is the worst.
And of course all the code is (probably) functional as is, and actually isn't completely terrible like it used to be, I'm just afraid it'll keep getting less and less maintainable if nobody ever cleans it (because the whole thing where bad code encourages even worse code, where people have to create bad code to work around the pre-existing bad code that's too bad to fix)

I'll probably get back to working on this over the break (unless anyone else wants to?).
As far as I can see, the other places on the schedule with work to be done are

• back-end
  • simplifying the actual html for the schedule
• usability improvements
  • options organization
  • options menu display (I really don't like the hacky way I have implemented now)
  • mobile options menu
  • better mobile support with week view (somehow)
• features
  • clock? (that also doesn't look out-of-place on the schedule)

There's probably some other stuff I missed, but that's all I've been keeping in my notes/todo list.

i probably shouldve updated the issues with this stuff sometime, but that's hard.

[briankchan]

Actually, when I edit comments, the edited version doesn't get sent in the email notifications, does it?