Skip to content

compliance.md claims deleted attestations remain in exportSubjectData's export, but get_subject_attestations filters them out #1394

Description

@Haroldwonder

docs/compliance.md's "Export constraints" section states deleted attestations "remain in the on-chain export (they are still stored on the ledger). Soft-deleted records are included in attestations with attestation.deleted === true." This is false: request_deletion (src/attestation.rs:860-883) removes the attestation ID from the subject's index via Storage::remove_subject_attestation and ChunkedIndex::remove_subject, and the contract's public get_subject_attestations (src/query.rs:163-173) additionally filters if !a.deleted. TrustLinkClient.exportSubjectData (sdk/typescript/src/client.ts:1353) enumerates attestations exclusively via iterateSubjectAttestationsgetSubjectAttestations, so a deleted attestation can never appear in the export despite the summary.deletedAttestations counter in the same function implying it should.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions