-
Notifications
You must be signed in to change notification settings - Fork 10
Expand file tree
/
Copy pathserverHandlers.test.js
More file actions
325 lines (280 loc) · 11.9 KB
/
Copy pathserverHandlers.test.js
File metadata and controls
325 lines (280 loc) · 11.9 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
'use strict';
const chai = require('chai');
const sinon = require('sinon');
const rewire = require('rewire');
const { expect } = chai;
const sinon_chai = require('sinon-chai').default;
chai.use(sinon_chai);
const harper_logger = require('#src/utility/logging/harper_logger');
const user_schema = require('#src/security/user');
const harperBridge = require('#src/dataLayer/harperBridge/harperBridge').default;
// Note: rewire is used to access private functions (schemaHandler, userHandler, componentStatusRequestHandler)
// for testing validation logic, not for replacing dependencies with mocks
const server_itc_handlers = rewire('#js/server/itc/serverHandlers');
const { resetResources } = require('#src/resources/Resources');
describe('Test hdbChildIpcHandler module', () => {
const TEST_ERR = 'The roof is on fire';
const sandbox = sinon.createSandbox();
let log_error_stub;
let log_trace_stub;
before(() => {
log_error_stub = sandbox.stub(harper_logger, 'error');
sandbox.stub(harper_logger, 'info');
log_trace_stub = sandbox.stub(harper_logger, 'trace');
sandbox.stub(harper_logger, 'warn');
sandbox.stub(harper_logger, 'debug');
});
after(() => {
sandbox.restore();
});
afterEach(() => {
sandbox.resetHistory();
});
describe('Test user event handler function', () => {
let user_handler;
before(() => {
user_handler = server_itc_handlers.__get__('userHandler');
});
// Tests error handling: verifies errors from setUsersWithRolesCache are caught and logged
it('Test User Handler log error upon setUsersWithRolesCache failure', async () => {
const setUserStub = sandbox.stub(user_schema, 'setUsersWithRolesCache').throws({ name: TEST_ERR });
const test_event = {
type: 'user',
message: { originator: 12345 },
};
await user_handler(test_event);
// Verify the specific error was logged (not just any error)
expect(log_error_stub.args[0][0].name).to.equal(TEST_ERR);
setUserStub.restore();
});
// Tests validation: verifies valid events pass validation and reach the cache update
it('Test User Handler calls setUsersWithRolesCache on valid event', async () => {
const setUserStub = sandbox.stub(user_schema, 'setUsersWithRolesCache').resolves();
const resetReadTxnStub = sandbox.stub(harperBridge, 'resetReadTxn');
const test_event = {
type: 'user',
message: { originator: 12345 },
};
await user_handler(test_event);
// Verifies validation passed and handler proceeded to update cache
expect(setUserStub).to.have.been.calledOnce;
setUserStub.restore();
resetReadTxnStub.restore();
});
// Tests validation: invalid events should be rejected and logged
it('Test User Handler logs error on invalid event (missing type)', async () => {
const test_event = {
message: { originator: 12345 },
};
await user_handler(test_event);
expect(log_error_stub).to.have.been.called;
});
// Tests validation: invalid events should be rejected and logged
it('Test User Handler logs error on invalid event (missing message)', async () => {
const test_event = {
type: 'user',
};
await user_handler(test_event);
expect(log_error_stub).to.have.been.called;
});
// Tests listener registration: verifies addListener actually registers callbacks
it('Test User Handler addListener functionality', async () => {
const setUserStub = sandbox.stub(user_schema, 'setUsersWithRolesCache').resolves();
const resetReadTxnStub = sandbox.stub(harperBridge, 'resetReadTxn');
let listenerCalled = false;
user_handler.addListener(() => {
listenerCalled = true;
});
const test_event = {
type: 'user',
message: { originator: 12345 },
};
await user_handler(test_event);
// Verifies registered listener was actually invoked
expect(listenerCalled).to.be.true;
setUserStub.restore();
resetReadTxnStub.restore();
});
});
describe('Test schema event handler function', () => {
let schema_handler;
before(() => {
schema_handler = server_itc_handlers.__get__('schemaHandler');
});
// Tests validation: invalid events should be rejected and logged
it('Test Schema Handler logs error on invalid event (missing type)', async () => {
const test_event = {
message: { originator: 12345, operation: 'create_table', schema: 'test' },
};
await schema_handler(test_event);
expect(log_error_stub).to.have.been.called;
});
// Tests validation: invalid events should be rejected and logged
it('Test Schema Handler logs error on invalid event (missing message)', async () => {
const test_event = {
type: 'schema',
};
await schema_handler(test_event);
expect(log_error_stub).to.have.been.called;
});
});
describe('Test componentStatusRequestHandler function', () => {
let component_status_handler;
before(() => {
component_status_handler = server_itc_handlers.__get__('componentStatusRequestHandler');
});
// Tests validation: invalid events should be rejected and logged
it('Test componentStatusRequestHandler logs error on invalid event (missing type)', async () => {
const test_event = {
message: { originator: 1, requestId: 'req-123' },
};
await component_status_handler(test_event);
expect(log_error_stub).to.have.been.called;
});
// Tests validation: invalid events should be rejected and logged
it('Test componentStatusRequestHandler logs error on invalid event (missing message)', async () => {
const test_event = {
type: 'component_status_request',
};
await component_status_handler(test_event);
expect(log_error_stub).to.have.been.called;
});
// Tests validation: invalid events should be rejected and logged
it('Test componentStatusRequestHandler logs error on invalid event (missing originator)', async () => {
const test_event = {
type: 'component_status_request',
message: { requestId: 'req-123' },
};
await component_status_handler(test_event);
expect(log_error_stub).to.have.been.called;
});
// Tests happy path: valid events should be processed without validation errors
it('Test componentStatusRequestHandler processes valid event without error', async () => {
sandbox.resetHistory();
const test_event = {
type: 'component_status_request',
message: { originator: 1, requestId: 'req-456' },
};
await component_status_handler(test_event);
// Trace log confirms handler received and started processing the event
expect(log_trace_stub).to.have.been.called;
});
it('Test componentStatusRequestHandler sends response directly when originator is reachable', async () => {
sandbox.resetHistory();
const sendToThreadStub = sandbox.stub(global.threads, 'sendToThread').returns(true);
const test_event = {
type: 'component_status_request',
message: { originator: 7, requestId: 'req-789' },
};
await component_status_handler(test_event);
expect(sendToThreadStub).to.have.been.calledOnce;
expect(sendToThreadStub.firstCall.args[0]).to.equal(7);
const responseMessage = sendToThreadStub.firstCall.args[1];
expect(responseMessage.type).to.equal('component_status_response');
expect(responseMessage.message.requestId).to.equal('req-789');
// Should have a trace confirming direct send (no error/debug fallback)
expect(log_error_stub).to.not.have.been.called;
sendToThreadStub.restore();
});
it('Test componentStatusRequestHandler drops response silently when originator is unreachable', async () => {
sandbox.resetHistory();
const sendToThreadStub = sandbox.stub(global.threads, 'sendToThread').returns(false);
const test_event = {
type: 'component_status_request',
message: { originator: 42, requestId: 'req-dropped' },
};
await component_status_handler(test_event);
expect(sendToThreadStub).to.have.been.calledOnce;
// No error, no fallback broadcast — just a trace acknowledging the drop
expect(log_error_stub).to.not.have.been.called;
const traceCalls = log_trace_stub.getCalls().map((call) => String(call.args[0]));
expect(traceCalls.some((msg) => msg.includes('Dropping component status response'))).to.be.true;
sendToThreadStub.restore();
});
});
describe('Test resourceOpenApiRequestHandler function', () => {
let resource_openapi_handler;
let resources_instance;
before(() => {
resource_openapi_handler = server_itc_handlers.__get__('resourceOpenApiRequestHandler');
resources_instance = resetResources();
});
afterEach(() => {
resources_instance.clear();
});
// Tests validation: invalid events should be rejected and logged
it('logs error on invalid event (missing type)', async () => {
const test_event = {
message: { originator: 1, requestId: 42, serverHttpURL: 'http://localhost' },
};
await resource_openapi_handler(test_event);
expect(log_error_stub).to.have.been.called;
});
// Tests validation: invalid events should be rejected and logged
it('logs error on invalid event (missing message)', async () => {
const test_event = {
type: 'resource_openapi_request',
};
await resource_openapi_handler(test_event);
expect(log_error_stub).to.have.been.called;
});
// Tests validation: invalid events should be rejected and logged
it('logs error on invalid event (missing originator)', async () => {
const test_event = {
type: 'resource_openapi_request',
message: { requestId: 42, serverHttpURL: 'http://localhost' },
};
await resource_openapi_handler(test_event);
expect(log_error_stub).to.have.been.called;
});
// Tests guard: a thread with no registered resources must stay silent so that an app
// worker (which has real resources) responds first and the caller gets the correct spec.
it('does not respond when this thread has no registered resources', async () => {
sandbox.resetHistory();
const sendToThreadStub = sandbox.stub(global.threads, 'sendToThread').returns(true);
const test_event = {
type: 'resource_openapi_request',
message: { originator: 5, requestId: 99, serverHttpURL: 'http://localhost:9925' },
};
await resource_openapi_handler(test_event);
expect(sendToThreadStub).to.not.have.been.called;
expect(log_error_stub).to.not.have.been.called;
sendToThreadStub.restore();
});
it('sends OpenAPI response directly when originator is reachable', async () => {
sandbox.resetHistory();
// Resources.set wraps the argument as entry.Resource; passing {isError:true} makes
// generateJsonApi skip the entry so the spec is minimal but the send path is exercised.
resources_instance.set('test', { isError: true });
const sendToThreadStub = sandbox.stub(global.threads, 'sendToThread').returns(true);
const test_event = {
type: 'resource_openapi_request',
message: { originator: 5, requestId: 99, serverHttpURL: 'http://localhost:9925' },
};
await resource_openapi_handler(test_event);
expect(sendToThreadStub).to.have.been.calledOnce;
expect(sendToThreadStub.firstCall.args[0]).to.equal(5);
const responseMessage = sendToThreadStub.firstCall.args[1];
expect(responseMessage.type).to.equal('resource_openapi_response');
expect(responseMessage.message.requestId).to.equal(99);
expect(responseMessage.message.openapi).to.be.an('object');
expect(log_error_stub).to.not.have.been.called;
sendToThreadStub.restore();
});
it('drops response silently when originator is unreachable', async () => {
sandbox.resetHistory();
resources_instance.set('test', { isError: true });
const sendToThreadStub = sandbox.stub(global.threads, 'sendToThread').returns(false);
const test_event = {
type: 'resource_openapi_request',
message: { originator: 99, requestId: 7, serverHttpURL: 'http://localhost:9925' },
};
await resource_openapi_handler(test_event);
expect(sendToThreadStub).to.have.been.calledOnce;
expect(log_error_stub).to.not.have.been.called;
const traceCalls = log_trace_stub.getCalls().map((call) => String(call.args[0]));
expect(traceCalls.some((msg) => msg.includes('Dropping resource OpenAPI response'))).to.be.true;
sendToThreadStub.restore();
});
});
});