fix(databases): sync non-indexed attributes in initStores() on resetDatabases() (RE-7)

`initStores()` only merged indexed attributes back into `table.attributes`
when updating an existing table (e.g. after a hot-reload–triggered
`resetDatabases()`). Non-indexed, non-primary-key fields (e.g. `name: String`,
`breed: String`) were written to `attributesDbi` by `table()` in the
restarted worker and signalled via ITC, but the main thread's
`resetDatabases()` → `initStores()` path skipped them — leaving
`describe_database` returning only the old attribute list until a full
kill+restart.

Fix: extend the existing-table update loop in `initStores()` to add/replace
non-indexed attributes as well as indexed ones, and remove them when they
are no longer present in the persisted schema.

Adds two regression tests in schemaMigrationFragility.test.js (RE-7 suite).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: kriszyp

resources/databases.ts

@@ -620,6 +620,19 @@ function initStores(
 					if (existingAttribute) existingAttributes.splice(existingAttributes.indexOf(existingAttribute), 1, attribute);
 					else existingAttributes.push(attribute);
 					attributesUpdated = true;
+				} else if (!attribute.isPrimaryKey) {
+					// Non-indexed, non-primary-key attributes (e.g. plain schema fields like `name: String`)
+					// must also be kept in sync so that describe_database reflects schema changes after a
+					// hot-reload / worker restart. Without this, resetDatabases() re-reads these attributes
+					// from attributesDbi but never merges them back into table.attributes — causing stale
+					// schema metadata until a full kill+restart. (RE-7)
+					const existingIdx = existingAttributes.findIndex((ea) => ea.name === attribute.name);
+					if (existingIdx >= 0) {
+						existingAttributes.splice(existingIdx, 1, attribute);
+					} else {
+						existingAttributes.push(attribute);
+						attributesUpdated = true;
+					}
 				}
 			} catch (error) {
 				logger.error(`Error trying to update attribute`, attribute, existingAttributes, indices, error);
@@ -647,6 +660,10 @@ function initStores(
 					// we only remove attributes if they were indexed, in order to support dropAttribute that removes dynamic indexed attributes
 					existingAttributes.splice(existingAttributes.indexOf(existingAttribute), 1);
 					attributesUpdated = true;
+				} else if (!existingAttribute.isPrimaryKey) {
+					// Remove non-indexed attributes that are no longer present in the persisted schema.
+					existingAttributes.splice(existingAttributes.indexOf(existingAttribute), 1);
+					attributesUpdated = true;
 				}
 			}
 		}

unitTests/resources/schemaMigrationFragility.test.js

@@ -382,6 +382,79 @@ describe('schema-migration fragility: stale `changed` reused after re-fetch unde
 	});
 });
 
+describe('schema-migration fragility: non-indexed attributes missing from table.attributes after resetDatabases() (RE-7)', () => {
+	if (process.env.HARPER_STORAGE_ENGINE === 'lmdb') return;
+
+	const DB = 're7NonIndexedAttrs';
+	const TABLE = 'Pet';
+	const testRoot = path.resolve(__dirname, '../envDir/re7NonIndexedAttrs');
+	const dbDir = path.join(testRoot, terms.DATABASES_DIR_NAME);
+
+	before(async () => {
+		setMainIsWorker(true);
+		await fs.remove(testRoot);
+		await fs.mkdirp(dbDir);
+		env.setProperty(terms.HDB_SETTINGS_NAMES.HDB_ROOT_KEY, testRoot);
+		env.setProperty(terms.CONFIG_PARAMS.ROOTPATH, testRoot);
+		env.setProperty(terms.CONFIG_PARAMS.STORAGE_PATH, dbDir);
+		env.setProperty(terms.CONFIG_PARAMS.DATABASES, {});
+
+		resetDatabases();
+		// Initial schema: only the primary key
+		table({
+			table: TABLE,
+			database: DB,
+			attributes: [{ name: 'id', isPrimaryKey: true }],
+		});
+		// Simulate hot-reload: call table() again with an expanded schema (non-indexed fields).
+		// This is what the graphqlSchema plugin does in a restarted worker.
+		table({
+			table: TABLE,
+			database: DB,
+			attributes: [
+				{ name: 'id', isPrimaryKey: true },
+				{ name: 'name' },
+				{ name: 'breed' },
+				{ name: 'age' },
+			],
+		});
+		// Simulate the ITC schema-change handler calling resetDatabases() in the main thread
+		// (the path that describe_database goes through).
+		resetDatabases();
+	});
+
+	after(async () => {
+		await fs.remove(testRoot);
+	});
+
+	it('table.attributes includes all non-indexed fields after resetDatabases()', () => {
+		const tbl = getDatabases()[DB]?.[TABLE];
+		assert.ok(tbl, `${DB}.${TABLE} should be registered after resetDatabases()`);
+		const attrNames = tbl.attributes.map((a) => a.name);
+		assert.ok(attrNames.includes('name'), `expected "name" in attributes, got: ${attrNames}`);
+		assert.ok(attrNames.includes('breed'), `expected "breed" in attributes, got: ${attrNames}`);
+		assert.ok(attrNames.includes('age'), `expected "age" in attributes, got: ${attrNames}`);
+	});
+
+	it('removes non-indexed attributes dropped from the schema after resetDatabases()', () => {
+		// Simulate schema shrinking (field removal), then another resetDatabases().
+		table({
+			table: TABLE,
+			database: DB,
+			attributes: [
+				{ name: 'id', isPrimaryKey: true },
+				{ name: 'name' },
+			],
+		});
+		resetDatabases();
+		const tbl = getDatabases()[DB]?.[TABLE];
+		const attrNames = tbl.attributes.map((a) => a.name);
+		assert.ok(attrNames.includes('name'), `expected "name" in attributes`);
+		assert.ok(!attrNames.includes('breed'), `"breed" should be removed, got: ${attrNames}`);
+		assert.ok(!attrNames.includes('age'), `"age" should be removed, got: ${attrNames}`);
+	});
+});
+
 describe('schema-migration fragility: stale store reused after LMDB to RocksDB engine migration (F4)', () => {
 	if (process.env.HARPER_STORAGE_ENGINE === 'lmdb') return;