fix: overwrite stale boot props when settings_path no longer exists (#1108)

* fix: overwrite stale boot props when settings_path no longer exists

If a previous install directory was deleted (e.g. a temp CI dir), the
boot props file persists pointing at a dead path. A reinstall with
ROOTPATH set would silently skip updating it, leaving every `harper`
invocation triggering the interactive wizard because isHdbInstalled()
fails against the missing path.

Now also rewrite boot props when the existing file's settings_path
resolves to a non-existent directory, regardless of ROOTPATH.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* refactor: anchor settings_path regex, strip quotes, flatten IIFE

Cross-model review flagged:
- regex without /m and line-start anchor could match commented-out
  settings_path lines and falsely flag a valid install as stale
- extracted path could include surrounding quotes if file was hand-edited
- IIFE was harder to follow and ran existsSync twice

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: kriszyp

utility/install/installer.ts

@@ -441,9 +441,28 @@ async function createBootPropertiesFile() {
 		const homeDirPath = path.join(homeDir, hdbTerms.HDB_HOME_DIR_NAME);
 		const homeDirKeysDirPath = path.join(homeDirPath, hdbTerms.LICENSE_KEY_DIR_NAME);
 		const propsFilePath = path.join(homeDirPath, hdbTerms.BOOT_PROPS_FILE_NAME);
-		// if the properties file already exists, and we have an explicit ROOTPATH, we don't overwrite the existing
-		// properties file
-		if (!fs.existsSync(propsFilePath) || !hdbUtils.getEnvCliRootPath()) {
+		// Write boot props when: file doesn't exist, OR no explicit ROOTPATH was given (caller
+		// accepts whatever path this install produces), OR the existing file points to a
+		// settings_path that no longer exists (stale from a deleted previous install dir).
+		let shouldWriteBootProps = !fs.existsSync(propsFilePath) || !hdbUtils.getEnvCliRootPath();
+		if (!shouldWriteBootProps) {
+			try {
+				const content = fs.readFileSync(propsFilePath, 'utf8');
+				// Anchor to line start (with /m) to avoid matching commented-out lines.
+				const match = content.match(/^[ \t]*settings_path\s*=\s*(.+)/m);
+				if (match) {
+					const settingsPath = match[1].trim().replace(/^["']|["']$/g, '');
+					if (!fs.existsSync(settingsPath)) {
+						shouldWriteBootProps = true;
+					}
+				} else {
+					shouldWriteBootProps = true;
+				}
+			} catch {
+				shouldWriteBootProps = true;
+			}
+		}
+		if (shouldWriteBootProps) {
 			try {
 				fs.mkdirpSync(homeDirPath, { mode: hdbTerms.HDB_FILE_PERMISSIONS });
 				fs.mkdirpSync(homeDirKeysDirPath, { mode: hdbTerms.HDB_FILE_PERMISSIONS });