Skip to content

Commit 7018834

Browse files
authored
Merge pull request #1175 from HarperFast/kris/fix-log-rotator-regression
fix(logging): scope logRotator state per instance
2 parents 2b9972e + 522d1f4 commit 7018834

1 file changed

Lines changed: 2 additions & 5 deletions

File tree

utility/logging/logRotator.ts

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,6 @@ const LOG_AUDIT_INTERVAL = 60000;
1818
const INT_SIZE_UNDEFINED_MSG =
1919
"'interval' and 'maxSize' are both undefined, to enable logging rotation at least one of these values must be defined in harperdb-config.yaml";
2020

21-
let lastRotationTime;
22-
let setIntervalId;
23-
2421
export { logRotator };
2522

2623
/**
@@ -67,9 +64,9 @@ function logRotator({ logger, maxSize, interval, retention, enabled, path: rotat
6764

6865
let lastRotatedLogPath;
6966
// convert date.now to minutes
70-
lastRotationTime = Date.now();
67+
let lastRotationTime = Date.now();
7168
hdbLogger.trace('Log rotate enabled, maxSize:', maxSize, 'interval:', interval);
72-
setIntervalId = setInterval(async () => {
69+
const setIntervalId = setInterval(async () => {
7370
if (maxBytes) {
7471
let fileStats;
7572
try {

0 commit comments

Comments
 (0)