Commit e3cf4c9
Bound the chained-commit test's wait so a regression can't hang the suite
Per codex's independent pre-push review: an unbounded await on secondCommitStarted would
hang forever if a regression ever prevented TrackB's commit from being invoked (or done
rejected before reaching it). Mocha's own test timeout does not cancel a still-running async
test function, so the try/finally's cleanup — restoring the monkeypatched
Transaction.prototype.commit and releasing the held promise — would never run, breaking
every later RocksDB-touching test in the process. Race the signal against a bounded timeout
so the finally block always gets a chance to run.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>1 parent 3e77025 commit e3cf4c9
1 file changed
Lines changed: 12 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
129 | 129 | | |
130 | 130 | | |
131 | 131 | | |
132 | | - | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
133 | 144 | | |
134 | 145 | | |
135 | 146 | | |
| |||
0 commit comments