Commit f1d09b7
test(integration): address Gemini review — harden waitFor/awaitJob
Apply the three medium-priority suggestions from the gemini-code-assist
review on PR #1233:
- waitFor: wrap produce/until in try/catch, swallowing a transient failure
(e.g. a momentary non-200 under CI contention) and retrying; re-throw only
on the final attempt so a persistent failure still surfaces. Supersedes the
earlier "keep it strict" choice — the retry-then-final-rethrow semantic is
the better default for a reusable contention-riding poll helper.
- awaitJob: optional-chain response.body?.[0]?.status to avoid a TypeError on
a null/empty body.
- row_count assertion: optional-chain r.body?.[0]?.row_count so a malformed
body yields a clean assertion diff rather than a property-access throw.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>1 parent 616f0df commit f1d09b7
2 files changed
Lines changed: 12 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8760 | 8760 | | |
8761 | 8761 | | |
8762 | 8762 | | |
8763 | | - | |
| 8763 | + | |
8764 | 8764 | | |
8765 | 8765 | | |
8766 | 8766 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
31 | | - | |
| 31 | + | |
32 | 32 | | |
33 | 33 | | |
34 | 34 | | |
| |||
87 | 87 | | |
88 | 88 | | |
89 | 89 | | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
90 | 94 | | |
91 | 95 | | |
92 | 96 | | |
| |||
95 | 99 | | |
96 | 100 | | |
97 | 101 | | |
98 | | - | |
99 | | - | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
100 | 108 | | |
101 | 109 | | |
102 | 110 | | |
| |||
0 commit comments