Skip to content

Commit c673dc9

Browse files
Resolve CI conflicts, skip PR logins, and restore original image name
1 parent af09dcf commit c673dc9

1 file changed

Lines changed: 3 additions & 5 deletions

File tree

.github/workflows/docker.yml

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,14 @@ on:
44
push:
55
branches:
66
- main
7-
- fix/docker-deployment # <--- This lets you test in your fork!
7+
# - fix/docker-deployment
88
pull_request:
99
branches:
1010
- main
11-
workflow_dispatch: # <--- Adds a button to run it manually
11+
workflow_dispatch:
1212

1313
env:
14-
IMAGE_NAME: specializedboy/mirage-git # <--- Updated to your Docker Hub username
14+
IMAGE_NAME: fabnemepfl/mirage
1515
REGISTRY: docker.io
1616

1717
jobs:
@@ -64,7 +64,6 @@ jobs:
6464
uses: actions/checkout@v4
6565

6666
- name: Log in to DockerHub
67-
# MAGIC FIX: Skip login if this is a PR (fixes the upstream crash)
6867
if: github.event_name != 'pull_request'
6968
uses: docker/login-action@v3
7069
with:
@@ -79,7 +78,6 @@ jobs:
7978
with:
8079
context: .
8180
file: ${{ matrix.path }}
82-
# MAGIC FIX: Only push if it is NOT a PR
8381
push: ${{ github.event_name != 'pull_request' }}
8482
tags: |
8583
${{ secrets.DOCKER_USERNAME }}/${{ matrix.name }}:latest-${{ matrix.tag_base }}

0 commit comments

Comments
 (0)