♻️ refactor: add lint suppression comments for file operations in multiple packages

Author: CarlosHe

internal/adapters/secondary/filesystem/fs.go

@@ -29,7 +29,7 @@ func NewOSFileSystem() *OSFileSystem {
 //
 //nolint:gosec,nolintlint // Filesystem adapter - file access controlled by caller
 func (fs *OSFileSystem) ReadFile(name string) ([]byte, error) {
-	return os.ReadFile(name)
+	return os.ReadFile(name) // #nosec G304 -- Filesystem adapter, paths controlled by caller
 }
 
 // WriteFile writes data to a file with the given permissions.
@@ -66,14 +66,14 @@ func (fs *OSFileSystem) Rename(oldpath, newpath string) error {
 //
 //nolint:gosec,nolintlint // Filesystem adapter - file access controlled by caller
 func (fs *OSFileSystem) Open(name string) (io.ReadCloser, error) {
-	return os.Open(name)
+	return os.Open(name) // #nosec G304 -- Filesystem adapter, paths controlled by caller
 }
 
 // Create creates or truncates the named file.
 //
 //nolint:gosec,nolintlint // Filesystem adapter - file access controlled by caller
 func (fs *OSFileSystem) Create(name string) (io.WriteCloser, error) {
-	return os.Create(name)
+	return os.Create(name) // #nosec G304 -- Filesystem adapter, paths controlled by caller
 }
 
 // Exists returns true if the file exists.

internal/core/services/compiler/executor.go

@@ -95,8 +95,7 @@ func compile(dprojPath string, dep *domain.Dependency, rootLock domain.PackageLo
 	abs, _ := filepath.Abs(filepath.Dir(dprojPath))
 	buildLog := filepath.Join(abs, fileRes+".log")
 	buildBat := filepath.Join(abs, fileRes+".bat")
-	//nolint:gosec,nolintlint // Reading Delphi environment variables file from known location
-	readFile, err := os.ReadFile(rsvars)
+	readFile, err := os.ReadFile(rsvars) // #nosec G304 -- Reading Delphi environment variables file from known location
 	if err != nil {
 		msg.Err("    ❌ Error on read rsvars.bat")
 	}

internal/core/services/paths/paths.go

@@ -20,7 +20,7 @@ func EnsureCleanModulesDir(dependencies []domain.Dependency, lock domain.Package
 	cacheDir := env.GetModulesDir()
 	cacheDirInfo, err := os.Stat(cacheDir)
 	if os.IsNotExist(err) {
-		err = os.MkdirAll(cacheDir, 0755)
+		err = os.MkdirAll(cacheDir, 0755) // #nosec G301 -- Standard permissions for cache directory
 		if err != nil {
 			msg.Die("❌ Failed to create modules directory: %v", err)
 		}
@@ -71,7 +71,7 @@ func EnsureCacheDir(config env.ConfigProvider, dep domain.Dependency) {
 	fi, err := os.Stat(cacheDir)
 	if err != nil {
 		msg.Debug("Creating %s", cacheDir)
-		err = os.MkdirAll(cacheDir, 0755)
+		err = os.MkdirAll(cacheDir, 0755) // #nosec G301 -- Standard permissions for cache directory
 		if err != nil {
 			msg.Die("❌ Could not create %s: %s", cacheDir, err)
 		}

pkg/env/configuration.go

@@ -143,15 +143,13 @@ func (c *Configuration) SaveConfiguration() {
 		msg.Die("❌ Failed to parse config file", err.Error())
 	}
 
-	//nolint:gosec,nolintlint // Standard permissions for Boss cache directory
-	err = os.MkdirAll(c.path, 0755)
+	err = os.MkdirAll(c.path, 0755) // #nosec G301 -- Standard permissions for Boss cache directory
 	if err != nil {
 		msg.Die("❌ Failed to create path", c.path, err.Error())
 	}
 
 	configPath := filepath.Join(c.path, consts.BossConfigFile)
-	//nolint:gosec,nolintlint // Creating Boss configuration file in known location
-	f, err := os.Create(configPath)
+	f, err := os.Create(configPath) // #nosec G304 -- Creating Boss configuration file in known location
 	if err != nil {
 		msg.Die("❌ Failed to create file ", configPath, err.Error())
 		return
@@ -186,8 +184,7 @@ func LoadConfiguration(cachePath string) (*Configuration, error) {
 	}
 
 	configFileName := filepath.Join(cachePath, consts.BossConfigFile)
-	//nolint:gosec,nolintlint // Reading Boss configuration file from cache directory
-	buffer, err := os.ReadFile(configFileName)
+	buffer, err := os.ReadFile(configFileName) // #nosec G304 -- Reading Boss configuration file from cache directory
 	if err != nil {
 		return makeDefault(cachePath), err
 	}

setup/migrations.go

@@ -54,8 +54,7 @@ func seven() {
 	if _, err := os.Stat(bossCfg); os.IsNotExist(err) {
 		return
 	}
-	//nolint:gosec,nolintlint // Reading Boss configuration file from known location
-	file, err := os.Open(bossCfg)
+	file, err := os.Open(bossCfg) // #nosec G304 -- Reading Boss configuration file from known location
 	if err != nil {
 		msg.Warn("⚠️ Migration 7: could not open config file: %v", err)
 		return

setup/setup.go

@@ -70,7 +70,7 @@ func initializeInfrastructure() {
 func CreatePaths() {
 	_, err := os.Stat(env.GetGlobalEnvBpl())
 	if os.IsNotExist(err) {
-		_ = os.MkdirAll(env.GetGlobalEnvBpl(), 0755)
+		_ = os.MkdirAll(env.GetGlobalEnvBpl(), 0755) // #nosec G301 -- Standard permissions for shared directory
 	}
 }
 

utils/dcp/dcp.go

@@ -52,8 +52,7 @@ func InjectDpcsFile(fileName string, pkg *domain.Package, lock domain.PackageLoc
 
 // readFile reads a file with Windows1252 encoding.
 func readFile(filename string) string {
-	//nolint:gosec,nolintlint // Reading DCP files from controlled package directories
-	f, err := os.Open(filename)
+	f, err := os.Open(filename) // #nosec G304 -- Reading DCP files from controlled package directories
 	if err != nil {
 		msg.Die(err.Error())
 	}
@@ -69,8 +68,7 @@ func readFile(filename string) string {
 
 // writeFile writes a file with Windows1252 encoding.
 func writeFile(filename string, content string) {
-	//nolint:gosec,nolintlint // Writing DCP files to controlled package directories
-	f, err := os.Create(filename)
+	f, err := os.Create(filename) // #nosec G304 -- Writing DCP files to controlled package directories
 	if err != nil {
 		msg.Die(err.Error())
 	}

utils/hash.go

@@ -34,8 +34,7 @@ func HashDir(dir string) string {
 			return nil
 		}
 
-		//nolint:gosec,nolintlint // Reading files from controlled directory structure for hashing
-		fileBytes, _ := os.ReadFile(path)
+		fileBytes, _ := os.ReadFile(path) // #nosec G304 -- Reading files from controlled directory structure for hashing
 		fileHash := hashByte(&fileBytes)
 		finalHash += fileHash
 		return nil

utils/librarypath/librarypath.go

@@ -96,8 +96,7 @@ func setReadOnlyProperty(dir string) {
 		msg.Warn("  ⚠️ Error on create build file")
 	}
 
-	//nolint:gosec,nolintlint // Executing controlled batch file with readonly attributes
-	cmd := exec.Command(readonlybat)
+	cmd := exec.Command(readonlybat) // #nosec G204 -- Executing controlled batch file with readonly attributes
 
 	_, err = cmd.Output()
 	if err != nil {