feat(sitewide): add scroll to top button to conditionally appear in longer pages #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inning of the page
esthersoftwaredev
requested changes
Mar 26, 2024
1.renaming variable : enableScrollUp-showScrollButton method : goPageTop-scrollToTop 2. hostlistener used instead of rxjs scroll evnt sub 3.window.pageYoffet or document.scrollTop value is used instead of cal scroll percentage. 4.space before ButtonModule
esthersoftwaredev
changed the title
esthersoftwaredev
added
🌟feature
esthersoftwaredev
approved these changes
Mar 27, 2024
esteecodes
approved these changes
Mar 27, 2024
copypasteov
approved these changes
Mar 27, 2024
|
@DongreJaipal thank you for your contribution 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Closes Issue closes
#28
Description
long blog posts there should be a scroll to pop button / icon that returns the user to the beginning of the page
for this app version primeicons used
applied in the app.component
What type of PR is this? (check all applicable)
Mobile & Desktop Screenshots/Recordings
[Attach screenshots or recordings if applicable]
Steps to QA
Added to documentation?
[Optional] Post-deployment tasks
[Specify any post-deployment tasks that need to be performed]
[Optional] What gif best describes this PR or how it makes you feel?
[Embed gif or describe the feeling in plain text]