Rename RETENTION_DAYS to OLD_FILE_THRESHOLD

Author: brian-kim31

app/api/files/views.py

@@ -35,7 +35,7 @@ class FileDownloadView(
     - Download a specific file by its primary key.
     - Request the generation of a file for download by sending a message to a queue.
     - Delete a file manually from storage and database.
-    - Automatically filter files older than FILE_RETENTION_DAYS from the list.
+    - Automatically filter files older than OLD_FILE_THRESHOLD from the list.
     Attributes:
         serializer_class (Serializer): The serializer class used for file downloads.
         filter_backends (list): The list of filter backends for filtering querysets.
@@ -45,7 +45,7 @@ class FileDownloadView(
     Methods:
         get_queryset():
             Retrieves the queryset of FileDownload objects filtered by the scan report ID
-            and age (files older than FILE_RETENTION_DAYS are excluded).
+            and age (files older than OLD_FILE_THRESHOLD are excluded).
         get(request, *args, **kwargs):
             Handles GET requests. If a primary key is provided, it downloads the file.
             Otherwise, it returns a paginated list of files.
@@ -67,7 +67,7 @@ def get_queryset(self):
         scan_report = get_object_or_404(ScanReport, pk=scan_report_id)
 
         # Return all non-deleted files
-        # Frontend will handle hiding files older than FILE_RETENTION_DAYS
+        # Frontend will handle hiding files older than OLD_FILE_THRESHOLD
         return FileDownload.objects.filter(
             scan_report=scan_report,
             deleted_at__isnull=True,
@@ -150,9 +150,7 @@ def post(self, request, *args, **kwargs):
             file_type_description = (
                 "JSON V1"
                 if file_type == "application/json_v1"
-                else "JSON V2"
-                if file_type == "application/json_v2"
-                else "CSV"
+                else "JSON V2" if file_type == "application/json_v2" else "CSV"
             )
             Job.objects.create(
                 scan_report=ScanReport.objects.get(id=scan_report_id),

app/next-client-app/app/(protected)/scanreports/[id]/downloads/FileDownloadsTable.tsx

@@ -5,7 +5,7 @@ import { ColumnDef } from "@tanstack/react-table";
 import { DataTable } from "@/components/data-table";
 import { Button } from "@/components/ui/button";
 import { Eye, EyeOff } from "lucide-react";
-import { FILE_RETENTION_DAYS } from "@/constants/config";
+import { OLD_FILE_THRESHOLD } from "@/constants/config";
 
 interface FileDownloadsTableProps {
   data: FileDownload[];
@@ -26,7 +26,7 @@ export function FileDownloadsTable({
 
   const cutoffDate = useMemo(() => {
     const millisecondsPerDay = 24 * 60 * 60 * 1000;
-    return new Date(Date.now() - FILE_RETENTION_DAYS * millisecondsPerDay);
+    return new Date(Date.now() - OLD_FILE_THRESHOLD * millisecondsPerDay);
   }, []);
 
   const { recentFiles, oldFiles } = useMemo(() => {

app/next-client-app/constants/config.js

@@ -3,13 +3,12 @@ const MAX_FILE_SIZE_BYTES = process.env.NEXT_PUBLIC_BODY_SIZE_LIMIT
   ? parseInt(process.env.NEXT_PUBLIC_BODY_SIZE_LIMIT, 10)
   : 31457280; // 30MB in bytes
 
-// File retention period in days (configurable via env, default 6 hours for testing)
-// 6 hours = 0.25 days
-const FILE_RETENTION_DAYS = process.env.NEXT_PUBLIC_FILE_RETENTION_DAYS
-  ? parseFloat(process.env.NEXT_PUBLIC_FILE_RETENTION_DAYS)
-  : 0.25;
+// Old file threshold in days - files older than this are auto-hidden in the UI
+const OLD_FILE_THRESHOLD = process.env.NEXT_PUBLIC_OLD_FILE_THRESHOLD
+  ? parseFloat(process.env.NEXT_PUBLIC_OLD_FILE_THRESHOLD)
+  : 30;
 
 module.exports = {
   MAX_FILE_SIZE_BYTES,
-  FILE_RETENTION_DAYS,
+  OLD_FILE_THRESHOLD,
 }; 

docker-compose.yml

@@ -77,7 +77,7 @@ services:
       - RECOMMENDATION_SERVICE_BASE_URL=https://api.hyperunison.com/api/public/suggester/generate
       - RECOMMENDATION_SERVICE_API_KEY=unison-api-key
       - NEXT_PUBLIC_BODY_SIZE_LIMIT=31457280
-      - NEXT_PUBLIC_FILE_RETENTION_DAYS=30
+      - NEXT_PUBLIC_OLD_FILE_THRESHOLD=30
     volumes:
       - ./app/next-client-app:/app
       - /app/node_modules