Skip to content

Commit dc3e6fb

Browse files
committed
Restrict unmapped filter to values page only
- Add showUnmappedFilter prop to ConceptDataFilter (defaults to false) - Pass showUnmappedFilter only on the values page, not the fields page - Remove unused Button, Link, ArrowLeft imports from values page
1 parent 0365a83 commit dc3e6fb

2 files changed

Lines changed: 14 additions & 15 deletions

File tree

app/next-client-app/app/(protected)/scanreports/[id]/tables/[tableId]/fields/[fieldId]/page.tsx

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,6 @@ import { columns } from "./columns";
99
import { ConceptDataTableV3 } from "@/components/concepts/ConceptDataTableV3";
1010
import { TableBreadcrumbs } from "@/components/scanreports/TableBreadcrumbs";
1111
import { ConceptDataFilter } from "@/components/concepts/ConceptDataFilter";
12-
import { Button } from "@/components/ui/button";
13-
import Link from "next/link";
14-
import { ArrowLeft } from "lucide-react";
1512

1613
interface ScanReportsValueProps {
1714
params: Promise<{
@@ -44,7 +41,7 @@ export default async function ScanReportsValue(props: ScanReportsValueProps) {
4441
query,
4542
);
4643

47-
const filter = <ConceptDataFilter />;
44+
const filter = <ConceptDataFilter showUnmappedFilter />;
4845

4946
const canEdit =
5047
permissions.permissions.includes("CanEdit") ||

app/next-client-app/components/concepts/ConceptDataFilter.tsx

Lines changed: 13 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ const ConceptDataOptions = [
2626
},
2727
]
2828

29-
export function ConceptDataFilter() {
29+
export function ConceptDataFilter({ showUnmappedFilter = false }: { showUnmappedFilter?: boolean }) {
3030
const router = useRouter();
3131
const searchParam = useSearchParams();
3232

@@ -103,16 +103,18 @@ export function ConceptDataFilter() {
103103
handleSelect={handleSelectOption}
104104
handleClear={() => (setOptions([]), handleFacetsFilter())}
105105
/>
106-
<div className="flex items-center gap-2">
107-
<Checkbox
108-
id="unmapped-only"
109-
checked={unmappedOnly}
110-
onCheckedChange={(checked) => handleUnmappedToggle(checked === true)}
111-
/>
112-
<Label htmlFor="unmapped-only" className="cursor-pointer">
113-
Unmapped only
114-
</Label>
115-
</div>
106+
{showUnmappedFilter && (
107+
<div className="flex items-center gap-2">
108+
<Checkbox
109+
id="unmapped-only"
110+
checked={unmappedOnly}
111+
onCheckedChange={(checked) => handleUnmappedToggle(checked === true)}
112+
/>
113+
<Label htmlFor="unmapped-only" className="cursor-pointer">
114+
Unmapped only
115+
</Label>
116+
</div>
117+
)}
116118
</div>
117119
);
118120
}

0 commit comments

Comments
 (0)