Skip to content

Fix downloads - #1215

Merged
AndyRae merged 4 commits into
masterfrom
fix/download-file
Sep 29, 2025
Merged

Fix downloads#1215
AndyRae merged 4 commits into
masterfrom
fix/download-file

Conversation

@AndyRae

@AndyRae AndyRae commented Sep 28, 2025

Copy link
Copy Markdown
Member
🦋 Bug Fix

PR Description

  • Add streaming API route at /api/download/[scan_report_id]/[file_id] that proxies Django backend
  • Update downloadFile function to return downloadUrl for mapping rules files
  • Modify download button to use a direct link to this proxied API instead
  • Preserve existing blob-based approach for SR exports
  • Include proper authentication, error handling, and cache headers
  • Fixes large file download failures caused by memory buffering

Related Issues or other material

Related #1214

- Add streaming API route at /api/download/[scan_report_id]/[file_id] that proxies Django backend
- Update downloadFile function to return downloadUrl for mapping rules files
- Modify download button to use window.open() for streaming downloads
- Preserve existing blob-based approach for SR exports
- Include proper authentication, error handling, and cache headers
- Fixes large file download failures caused by memory buffering
@AndyRae
AndyRae marked this pull request as ready for review September 29, 2025 13:14
@github-actions github-actions Bot added dependencies Pull requests that update a dependency file Area: Backend Area: Airflow labels Sep 29, 2025
@AndyRae
AndyRae merged commit e959773 into master Sep 29, 2025
12 checks passed
@AndyRae
AndyRae deleted the fix/download-file branch September 29, 2025 13:24
@AndyRae AndyRae mentioned this pull request Sep 30, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: Airflow Area: Backend Area: Frontend dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant