fix: Bob's Buddy Sentry events failing to serialize with enchantments

Author: beheh

CHANGELOG.md

@@ -3,6 +3,7 @@
 - Updated the list of Trinkets that cause Tavern Tier 7 to appear.
 - Removed the distracting Bob's Buddy animation when hovering the leaderboard.
 - Fixed certain Battlegrounds overlay settings not taking effect immediately.
+- Fixed an issue with the instrumentation we use to fix incorrect combat odds.
 
 ## **Release v1.55.8 - 2026-08-14**
 **Battlegrounds**:

Hearthstone Deck Tracker/Utility/Analytics/Sentry.cs

@@ -15,6 +15,8 @@
 using Hearthstone_Deck_Tracker.Utility.Extensions;
 using Hearthstone_Deck_Tracker.Utility.Logging;
 using Hearthstone_Deck_Tracker.Utility.RemoteData;
+using Newtonsoft.Json;
+using Newtonsoft.Json.Linq;
 using SharpRaven;
 using SharpRaven.Data;
 
@@ -198,7 +200,7 @@ private static void SendQueuedBobsBuddyEvents(string? shortId, string path, Func
 				var e = BobsBuddyEvents.Dequeue();
 				((BobsBuddyData)e.Extra).ShortId = shortId;
 
-				var eventId = Client.Capture(recode(e));
+				var eventId = Client.Capture(WithSerializableExtra(recode(e)));
 				if(eventId != null)
 					sent++;
 				else
@@ -224,6 +226,20 @@ private static SentryEvent RecodeIfBothSidesEmpty(SentryEvent e)
 		private static SentryEvent RecodeAsStateCompleteFalse(SentryEvent e) =>
 			Recode(e, $"BobsBuddy {BobsBuddyUtils.VersionString}: Incorrect Terminal Case: StateCompleteFalse");
 
+		private static SentryEvent WithSerializableExtra(SentryEvent e)
+		{
+			if(e.Extra == null)
+				return e;
+			// BobsBuddy entities contain reference cycles (Enchantment.AttachedTo), which make SharpRaven's serialization throw
+			var serializer = JsonSerializer.Create(new JsonSerializerSettings
+			{
+				ReferenceLoopHandling = ReferenceLoopHandling.Ignore,
+				Error = (_, args) => args.ErrorContext.Handled = true,
+			});
+			e.Extra = JObject.FromObject(e.Extra, serializer);
+			return e;
+		}
+
 		private static SentryEvent Recode(SentryEvent e, string message) =>
 			new SentryEvent(new SentryMessage(message))
 			{