feat: add retry handling for comp stats connection failures

Author: ChrisNolan

Hearthstone Deck Tracker/Controls/Overlay/Battlegrounds/Session/BattlegroundsSession.xaml

@@ -190,17 +190,19 @@
                                         Visibility="{Binding CompStatsWaitingMsgVisibility, FallbackValue=Collapsed}"
                                         Margin="0 26 0 26"
                                     />
-                                    <TextBlock
-                                        Text="{lex:Loc Battlegrounds_Session_CompStats_ErrorMessage}"
-                                        Foreground="#FFFFFF"
-                                        Opacity=".5"
-                                        TextWrapping="WrapWithOverflow"
-                                        TextAlignment="Center"
-                                        HorizontalAlignment="Center"
-                                        VerticalAlignment="Center"
-                                        Visibility="{Binding CompStatsErrorVisibility, FallbackValue=Collapsed}"
-                                        Margin="0 26 0 26"
-                                    />
+                                    <StackPanel Orientation="Vertical" Visibility="{Binding CompStatsErrorVisibility, FallbackValue=Collapsed}" VerticalAlignment="Center" HorizontalAlignment="Center" Margin="0 16 0 16">
+                                        <TextBlock
+                                            Text="{lex:Loc Battlegrounds_Session_CompStats_ErrorMessage}"
+                                            Foreground="#FFFFFF"
+                                            Opacity=".5"
+                                            TextWrapping="WrapWithOverflow"
+                                            TextAlignment="Center"
+                                            HorizontalAlignment="Center"
+                                            Margin="4 0 4 8"
+                                        />
+                                        <Button Content="Retry" Command="{Binding RetryCompStatsCommand}" Width="64" HorizontalAlignment="Center" Style="{StaticResource Tier7ButtonStyle}" Cursor="Hand" />
+                                        <TextBlock Text="{Binding CompStatsDebugInfo}" Visibility="{Binding CompStatsDebugVisibility, FallbackValue=Collapsed}" Foreground="#FFFFFF" Opacity=".6" FontSize="10" TextWrapping="Wrap" Margin="6,6,6,0" />
+                                    </StackPanel>
                                 </Grid>
                             </StackPanel>
                         </StackPanel>

Hearthstone Deck Tracker/Controls/Overlay/Battlegrounds/Session/BattlegroundsSessionViewModel.xaml.cs

@@ -20,17 +20,24 @@
 using Hearthstone_Deck_Tracker.Utility.Logging;
 using Hearthstone_Deck_Tracker.Utility.MVVM;
 using Hearthstone_Deck_Tracker.Utility.RemoteData;
+using Hearthstone_Deck_Tracker.Commands;
 using HSReplay.Requests;
 using HSReplay.Responses;
 using Newtonsoft.Json;
 using static Hearthstone_Deck_Tracker.Utility.Battlegrounds.BattlegroundsLastGames;
+using System.Windows.Input;
 
 namespace Hearthstone_Deck_Tracker.Controls.Overlay.Battlegrounds.Session;
 
 public class BattlegroundsSessionViewModel : ViewModel
 {
 	private readonly BattlegroundsDb _db = BattlegroundsDbSingleton.Instance;
 
+	public BattlegroundsSessionViewModel()
+	{
+		RetryCompStatsCommand = new Command(async () => await RetryCompStats());
+	}
+
 	public ObservableCollection<Race> AvailableMinionTypes { get; } = new();
 	public ObservableCollection<Race> BannedMinionTypes { get; } = new();
 	public ObservableCollection<BattlegroundsGameViewModel> SessionGames { get; } = new();
@@ -50,6 +57,8 @@ public void OnGameEnd()
 
 	private readonly SemaphoreSlim _updateCompStatsSemaphore = new SemaphoreSlim(1, 1);
 
+	public ICommand RetryCompStatsCommand { get; }
+
 
 	public async void Update()
 	{
@@ -187,6 +196,20 @@ private void UpdateMinionTypes()
 
 	    var availableRaces = BattlegroundsUtils.GetAvailableRaces();
 
+	    // Retry logic: game state may not be ready immediately
+	    if(availableRaces == null)
+	    {
+		    Log.Info("[Tier7CompStats] Available races not ready, retrying after delay...");
+		    await Task.Delay(2000);
+		    availableRaces = BattlegroundsUtils.GetAvailableRaces();
+		    
+		    if(availableRaces == null)
+		    {
+			    await Task.Delay(3000);
+			    availableRaces = BattlegroundsUtils.GetAvailableRaces();
+		    }
+	    }
+
 	    if(availableRaces == null)
 		    throw new CompositionStatsException("Unable to get available races");
 
@@ -288,18 +311,28 @@ private async Task TrySetCompStats()
 		catch(Exception e)
 		{
 			HandleCompStatsError(e);
+			return;
 		}
 
 		if(battlegroundsCompStats is BattlegroundsCompStats compStats)
 		{
 			var firstPlaceComps = compStats.Data?.FirstPlaceCompsLobbyRaces;
-			if(firstPlaceComps != null)
+			if(firstPlaceComps != null && firstPlaceComps.Count > 0)
 			{
+				Log.Info($"[Tier7CompStats] Success: received {firstPlaceComps.Count} compositions");
 				SetBattlegroundsCompositionStatsViewModel(
 					firstPlaceComps
 				);
 				ShowCompositionStats();
 			}
+			else
+			{
+				Log.Warn($"[Tier7CompStats] API returned null or empty compositions. compStats.Data={compStats.Data}, firstPlaceComps.Count={firstPlaceComps?.Count ?? 0}");
+			}
+		}
+		else
+		{
+			Log.Warn($"[Tier7CompStats] Received null from API");
 		}
 	}
 
@@ -315,6 +348,7 @@ public void HideCompStatsOnError()
 	private void HandleCompStatsError(Exception error)
 	{
 		Influx.OnGetBattlegroundsCompositionStatsError(error.GetType().Name, error.Message);
+		Log.Error($"[Tier7CompStats] error: {error.GetType().Name} - {error.Message}; debug={CompStatsDebugInfo ?? "<none>"}");
 
 		var beforeHeroPicked = (Core.Game.GameEntity?.GetTag(GameTag.STEP) ?? 0) <= (int)Step.BEGIN_MULLIGAN;
 		if(!beforeHeroPicked)
@@ -332,6 +366,23 @@ private void HandleCompStatsError(Exception error)
 		CompStatsWaitingMsgVisibility = Visibility.Hidden;
 	}
 
+	private async Task RetryCompStats()
+	{
+		CompStatsErrorVisibility = Visibility.Hidden;
+		CompStatsBodyVisibility = Visibility.Hidden;
+		CompStatsWaitingMsgVisibility = Visibility.Visible;
+
+		try
+		{
+			await _updateCompStatsSemaphore.WaitAsync();
+			await TrySetCompStats();
+		}
+		finally
+		{
+			_updateCompStatsSemaphore.Release();
+		}
+	}
+
 	private async Task<GameItem?> UpdateLatestGames()
 	{
 		var sortedGames = (await Instance.PlayerGames(IsDuos))
@@ -529,6 +580,20 @@ public Visibility CompStatsErrorVisibility
 		}
 	}
 
+	private string? _compStatsDebugInfo;
+	public string? CompStatsDebugInfo
+	{
+		get => _compStatsDebugInfo;
+		set
+		{
+			_compStatsDebugInfo = value;
+			OnPropertyChanged();
+			OnPropertyChanged(nameof(CompStatsDebugVisibility));
+		}
+	}
+
+	public Visibility CompStatsDebugVisibility => string.IsNullOrWhiteSpace(_compStatsDebugInfo) ? Visibility.Collapsed : Visibility.Visible;
+
 	private Visibility _compStatsWaitingMsgVisibility;
 	public Visibility CompStatsWaitingMsgVisibility
 	{