PHP 7.3 fixes

Author: Hedius

app/bfacp/Http/Controllers/HomeController.php

@@ -70,9 +70,12 @@ public function scoreboard()
 
                 return $p;
             })->lists('display_name', 'name');
-
+	
+    	    // compact throws a warning if a value is undefined
+ 	    set_error_handler(function() { /* ignore errors */ });
             $adminview = View::make('partials.scoreboard.admin.admin',
                 compact('validPermissions', 'presetMessages'))->render();
+	    restore_error_handler();
         } else {
             $adminview = null;
         }

app/config/app.php

@@ -74,7 +74,7 @@
      */
 
     'key'             => getenv('APP_KEY') ?: 'YourSecretKey!!!',
-    'cipher'          => MCRYPT_RIJNDAEL_256,
+    'cipher'          => 'AES-256-CBC',
     /*
     |--------------------------------------------------------------------------
     | Autoloaded Service Providers
@@ -96,7 +96,7 @@
         'Illuminate\Database\DatabaseServiceProvider',
         'Illuminate\Database\MigrationServiceProvider',
         'Illuminate\Database\SeedServiceProvider',
-        'Illuminate\Encryption\EncryptionServiceProvider',
+        'Tomgrohl\Laravel\Encryption\EncryptionServiceProvider',
         'Illuminate\Filesystem\FilesystemServiceProvider',
         'Illuminate\Foundation\Providers\ArtisanServiceProvider',
         'Illuminate\Foundation\Providers\ConsoleSupportServiceProvider',

bootstrap/start.php

@@ -69,7 +69,7 @@
     $setupFilePath = $app['path.base'] . '/app/bfacp/setup.php';
     $jsBuildsPath = $app['path.public'] . '/js/builds';
 
-    if (version_compare(phpversion(), '5.5.0', '<') || !extension_loaded('mcrypt') || !extension_loaded('pdo')) {
+    if (version_compare(phpversion(), '5.5.0', '<') || !extension_loaded('pdo')) {
         die(View::make('system.requirements', ['required_php_version' => '5.5.0']));
     }