"Force incognito mode" icon impossible to hide when in incognito mode

[d8f6]

Describe the bug
Okay, so I got word suggestions working in incognito mode which I am very happy about. The issue I have is that in incognito mode (on web browsers) the icon on the left stays visible for some reason. I looked through the icons and it seems to be called "Force incognito mode". I have all of these things turned off so in a regular browser session it does not appear, but in incognito mode it does. I tried tapping the icon, but it doesn't do anything at all. Like a placeholder almost.

To Reproduce
Hide all icons in word suggestion toolbar in settings, then open a regular browsing window and icon is gone, but in incognito browser tab/mode icon persists for some reason.

Expected behavior
Icon should not appear, as it does nothing and is disabled anyway.

App version
F-droid - version 3.6 (just updated, so I guess it is the newest?)

Device:

• Model: Pixel 3a
• OS: Lineageos (Android 11)

I filed as a bug as opposed to enhancement because it seems like behavior that is inconsistent. I did not see any duplicates (or didn't know what to search for), if this is a duplicate please let me know. Okay, thanks. Love the keyboard :)

[eranl]

The icon is there in order to indicate that you're in incognito mode.

[d8f6]

The icon is there in order to indicate that you're in incognito mode.

Oh, I see. So, it's a feature, not a bug? I am the one that setup the browser though, so I know it is in incognito mode (permanently)... Since I'm not a moron, why do I need this icon to remind me of this? Would it be possible to get a toggle to turn it off or something? This is the last thing I need to get rid of until this keyboard is basically perfect for my needs/feature complete (admittedly I do not use a lot of the built in features besides text correction and clipboard).

[MiMoHo]

The problem is clear and easy to fix @d8f6. The collapsed expand key (">") shows the incognito indicator whenever incognito is active — including when the current field/app forces it (your case: the browser's incognito tab sets IME_FLAG_NO_PERSONALIZED_LEARNING). When the toolbar isn't expandable it can't be hidden and does nothing on tap (the click listener is null there) — exactly the "placeholder" you saw.

I think the indicator is redundant: you can pin the incognito toolbar key, which shows the state in the collapsed strip and is actually toggleable. The extra "a field forced incognito" signal it added isn't really useful (a browser may still be saving the password itself, etc.). So I've removed the expand-key indicator in #2695 — the expand key is now always the plain arrow and is only shown when it can toggle the toolbar. That closes this.

[d8f6]

@MiMoHo Thank you. Will await the update :)