Skip to content

Commit 1052431

Browse files
Justin Torreclaude
authored andcommitted
fix: change skipS3Storage from || to && for omit headers
Only skip S3 storage when BOTH request AND response are omitted. Previously, omitting just one would skip S3 entirely, preventing the other from being visible in Jawn. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
1 parent 945eabe commit 1052431

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

worker/src/lib/dbLogger/DBLoggable.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -836,10 +836,10 @@ export class DBLoggable {
836836
// Ignore parsing errors - usage will be extracted later by Jawn if body is stored
837837
}
838838

839-
// Skip S3 storage if omit headers are set
840-
// Note: Free tier limit exceeded + PTB requests will still log but skip S3
839+
// Skip S3 storage only if BOTH request and response are omitted
840+
// If only one is omitted, still store to S3 - Jawn will respect the omit flags
841841
const skipS3Storage =
842-
requestHeaders?.omitHeaders?.omitRequest === true ||
842+
requestHeaders?.omitHeaders?.omitRequest === true &&
843843
requestHeaders?.omitHeaders?.omitResponse === true;
844844

845845
if (S3_ENABLED === "true" && !skipS3Storage) {

0 commit comments

Comments
 (0)