Skip to content

Commit c174403

Browse files
replicas-connector[bot]claudeclaude[bot]chitalian
authored
fix: filter out future requests from query-clickhouse endpoint (#5398)
* fix: filter out future requests from query-clickhouse endpoint When navigating to the request page from another page, some customers were seeing requests with timestamps far in the future (e.g., August when current date was October). This was caused by requests with incorrectly timestamped data appearing at the top of results. Added a filter `request_created_at <= now()` to both ClickHouse query functions to exclude any requests with future timestamps: - getRequestsClickhouseNoSort: used for created_at sorting - getRequestsClickhouse: used for other sort types Fixes ENG-3403 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * feat: add 1-minute buffer to future request filter Co-authored-by: Justin Torre <chitalian@users.noreply.github.com> --------- Co-authored-by: replicas-connector[bot] <replicas-connector[bot]@users.noreply.github.com> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: Justin Torre <chitalian@users.noreply.github.com>
1 parent 3b749b7 commit c174403

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

valhalla/jawn/src/lib/stores/request/request.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -171,11 +171,12 @@ export async function getRequestsClickhouseNoSort(
171171
const sortSQL = createdAtSort === "asc" ? "ASC" : "DESC";
172172
const query = `
173173
WITH top_requests AS (
174-
SELECT
174+
SELECT
175175
request_id,
176176
request_created_at
177177
FROM request_response_rmt
178178
WHERE (${builtFilter.filter})
179+
AND request_created_at <= now() + INTERVAL 1 MINUTE
179180
ORDER BY request_created_at ${sortSQL}
180181
LIMIT ${limit}
181182
OFFSET ${offset}
@@ -298,6 +299,7 @@ export async function getRequestsClickhouse(
298299
FROM request_response_rmt
299300
WHERE (
300301
(${builtFilter.filter})
302+
AND request_created_at <= now() + INTERVAL 1 MINUTE
301303
)
302304
${sortSQL !== undefined ? `ORDER BY ${sortSQL}` : ""}
303305
LIMIT ${limit}

0 commit comments

Comments
 (0)