Skip to content

fix: remove free limit logic from webhooks feature#4733

Merged
devinat1 merged 2 commits intomainfrom
devin/eng-3085-webhook-fix
Sep 11, 2025
Merged

fix: remove free limit logic from webhooks feature#4733
devinat1 merged 2 commits intomainfrom
devin/eng-3085-webhook-fix

Conversation

@devinat1
Copy link
Contributor

This pull request removes the free tier limit enforcement and related UI for webhooks, and adds tests covering basic webhook functionality.

@vercel
Copy link

vercel bot commented Sep 11, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
helicone Ready Ready Preview Comment Sep 11, 2025 9:38pm
helicone-eu Ready Ready Preview Comment Sep 11, 2025 9:38pm
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
helicone-bifrost Skipped Skipped Sep 11, 2025 9:38pm

@claude
Copy link
Contributor

claude bot commented Sep 11, 2025

Claude encountered an error —— View job


I'll analyze this and get back to you.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Summary

This PR removes free tier restrictions on webhooks functionality, making webhooks unlimited for all users regardless of their tier. The changes span three key areas:

  1. Frontend UI simplification: The webhooksPage.tsx component has been simplified by removing all free tier limit logic, including the useFeatureLimit hook, FreeTierLimitWrapper, and FreeTierLimitBanner components. The "Add Webhook" button is now always available without conditional rendering based on tier limits.

  2. Configuration cleanup: The freeTierLimits.ts file has been updated to remove the webhook configuration that previously limited free tier users to 1 webhook, along with associated description text and upgrade messaging.

  3. Test coverage addition: A comprehensive test suite has been added for the WebhookStore class, providing extensive coverage including happy path scenarios, error handling, edge cases, and concurrent operations.

The changes align the codebase with a product decision to make webhooks freely available to all users. Previously, the webhook functionality was artificially restricted through UI logic that wasn't properly backed by the centralized feature configuration system. This change eliminates that inconsistency and simplifies the webhook management interface while ensuring robust test coverage for the underlying functionality.

Confidence score: 5/5

  • This PR is safe to merge with minimal risk as it removes restrictive logic rather than adding complex new functionality
  • Score reflects well-structured changes that align UI behavior with business logic, plus comprehensive test coverage for existing functionality
  • No files require special attention as the changes are straightforward removals and the new test file provides thorough coverage

3 files reviewed, no comments

Edit Code Review Bot Settings | Greptile

@devinat1 devinat1 merged commit e99b01b into main Sep 11, 2025
10 of 11 checks passed
@devinat1 devinat1 deleted the devin/eng-3085-webhook-fix branch September 11, 2025 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants