fix: remove free limit logic from webhooks feature#4733
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
There was a problem hiding this comment.
Greptile Summary
This PR removes free tier restrictions on webhooks functionality, making webhooks unlimited for all users regardless of their tier. The changes span three key areas:
-
Frontend UI simplification: The
webhooksPage.tsxcomponent has been simplified by removing all free tier limit logic, including theuseFeatureLimithook,FreeTierLimitWrapper, andFreeTierLimitBannercomponents. The "Add Webhook" button is now always available without conditional rendering based on tier limits. -
Configuration cleanup: The
freeTierLimits.tsfile has been updated to remove the webhook configuration that previously limited free tier users to 1 webhook, along with associated description text and upgrade messaging. -
Test coverage addition: A comprehensive test suite has been added for the
WebhookStoreclass, providing extensive coverage including happy path scenarios, error handling, edge cases, and concurrent operations.
The changes align the codebase with a product decision to make webhooks freely available to all users. Previously, the webhook functionality was artificially restricted through UI logic that wasn't properly backed by the centralized feature configuration system. This change eliminates that inconsistency and simplifies the webhook management interface while ensuring robust test coverage for the underlying functionality.
Confidence score: 5/5
- This PR is safe to merge with minimal risk as it removes restrictive logic rather than adding complex new functionality
- Score reflects well-structured changes that align UI behavior with business logic, plus comprehensive test coverage for existing functionality
- No files require special attention as the changes are straightforward removals and the new test file provides thorough coverage
3 files reviewed, no comments
This pull request removes the free tier limit enforcement and related UI for webhooks, and adds tests covering basic webhook functionality.