fix: concatenate reasoning field in streaming response consolidation#5578
Merged
chitalian merged 1 commit intoHelicone:mainfrom Feb 17, 2026
Merged
Conversation
consolidateTextFields() only concatenated content and function_call from streaming deltas, but not reasoning. This meant reasoning tokens from providers like Gemini with thinking/reasoning would get last-chunk-wins behavior instead of proper concatenation. Adds reasoning field handling alongside content in the delta consolidation logic.
|
@ink-the-squid is attempting to deploy a commit to the Helicone Team on Vercel. A member of the Team first needs to authorize it. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
consolidateTextFields()inresponseParserHelpers.tsonly concatenatescontentandfunction_callfrom streaming deltas, but ignoresreasoning. This means reasoning tokens from providers like Gemini 2.5 (with thinking/reasoning enabled) get last-chunk-wins behavior instead of proper concatenation when stored.Fix
Add
reasoningfield handling alongsidecontentin the delta consolidation logic — same pattern, same null-safety.Testing
reasoning_effort: high