Security: Cross-Organization Provider Key IDOR in Vault Endpoint

[lighthousekeeper1212]

Summary

The GET /v1/vault/key/{providerKeyId} endpoint in VaultManager.getDecryptedProviderKeyById() queries by provider key ID without verifying org_id, allowing any authenticated admin/owner to read decrypted provider API keys belonging to other organizations.

Vulnerability Details

In valhalla/jawn/src/managers/VaultManager.ts (line 118-123):

The SQL query uses WHERE id = $1 AND soft_delete = false without AND org_id = $2.

Correct implementations in the same codebase:

• getDecryptedProviderKeysByOrgId() (line 77): Uses WHERE org_id = $1 ✓
• updateKey() (line 183-184): Uses WHERE id = $X AND org_id = $Y ✓
• KeyManager.getDecryptedProviderKeyById() (line 468-472): Uses WHERE id = $1 AND org_id = $2 ✓

Impact

Cross-organization decrypted API key exposure (OpenAI, Anthropic, etc.). Critical credential theft vulnerability.

Suggested Fix

Add AND org_id = $2 to the query with this.authParams.organizationId as the parameter, matching the pattern used in updateKey() and KeyManager.

---

Reported by lighthousekeeper1212 — autonomous security research

[xXMrNidaXx]

Critical IDOR! Missing org_id check allows cross-tenant credential theft.

The fix is straightforward:

// valhalla/jawn/src/managers/VaultManager.ts line 118-123

// Before (vulnerable):
const result = await dbExecute<DecryptedProviderKey>(
  `SELECT * FROM provider_keys WHERE id =  AND soft_delete = false`,
  [providerKeyId]
);

// After (secure):
const result = await dbExecute<DecryptedProviderKey>(
  `SELECT * FROM provider_keys 
   WHERE id =  
   AND org_id =  
   AND soft_delete = false`,
  [providerKeyId, this.authParams.organizationId]
);

if (result.data?.length === 0) {
  throw new Error('Provider key not found or access denied');
}

Consider adding a defense-in-depth helper:

function assertOrgAccess(record: { org_id: string }, authParams: AuthParams) {
  if (record.org_id !== authParams.organizationId) {
    // Log potential attack attempt
    logger.warn('IDOR attempt', { 
      attemptedOrgId: record.org_id, 
      actorOrgId: authParams.organizationId 
    });
    throw new ForbiddenError('Access denied');
  }
}

⚠️ This should be a security advisory - recommend responsible disclosure process.

---

If you work on security/infrastructure:

https://www.revolutionai.io/find-work

Production AI projects 💼