computeScoresWithFormula() divides by solar.max_power_kw with no zero-guard, unlike its sibling computeScores()

[sshdopey]

Where: src/lib/scoring-formula.ts, computeScoresWithFormula()
(lines ~94-115).

What's wrong:

const powerComponent = (solar.power_output_kw / solar.max_power_kw) * 100 * w.power_weight;

There is no guard against solar.max_power_kw === 0. Compare with the
default scoring path in src/lib/scoring.ts:

const powerRatio = maxPower > 0 ? powerOutput / maxPower : POWER_RATIO_FALLBACK;

which explicitly falls back rather than dividing by zero. If
max_power_kw is 0 and power_output_kw is also 0 (a plausible reading
for an idle/misconfigured panel), 0 / 0 is NaN, which then propagates
through Math.max(0, Math.min(100, NaN)) → NaN, and
Math.round(NaN) → NaN. credit_quality ends up NaN instead of a
number.

Impact: this function is reachable via GET /v1/scoring/formulas/:id/preview/:projectId
(src/routes/scoring-formulas.ts), which feeds it live simulated
solar/satellite readings. A NaN credit_quality would flow into the
response's scores.withFormula/delta fields un-caught (no isNaN check
anywhere on this path), unlike computeScores, whose output is always a
finite number by construction.

Suggested fix: add the same zero-guard used in scoring.ts:
solar.max_power_kw > 0 ? solar.power_output_kw / solar.max_power_kw : 0.
There is no src/__tests__/scoring-formula.test.ts at all (confirmed: zero
references to scoring-formula/ScoringFormula anywhere under
src/__tests__) — add coverage for this edge case once fixed.

[Dekah101]

@Dekah101 has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

Hello maintainer, I would like to work on this.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Dekah101 to this issue.

[drips-wave]

Congratulations, @Dekah101! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on August 31, 2026.

🧑‍💻 @Dekah101: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

Warning

When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

🌊 Happy Wave 🌊