Brush selected event keeps firing

[tamirgilany]

Hello,
I have an issue with your plugin.

Every time I draw a brush and then I hove parts which are not brushed or even one which are. I see in the console that the selected event is fired.

I think this event should only be fire after I finished drawing the brush.

Also I facing some weird issues with the brush behavior of brush disappearing and jumping from place to place as you can see here in the gif

Is there any chance you can fix it?

Thanks!

[tamirgilany]

Hey @Heqingsong ,

Would love if you can have a look at this issue.

Thanks :)

[QuadTriangle]

@tamirgilany do you still need the fix? I have a quick fix for some problems (doesn't look so good).

[TGilany]

@QuadTriangle yes, it would be appreciated.
Thanks :)

[QuadTriangle]

@tamirgilany I have directly modified the dist (I needed 'just works' version :) )
https://gist.github.com/QuadTriangle/92e94f48308cc297ad1aa076a9488b97

check "Revisions" to see my fixes

changes:
selection event only on 'mouseup' event within the chart
remove global state (if you select/brush a chart, no other charts will be selected)
brush destroy on zoom
update zooming label based on item counts (you can ignore this)

(if you destroy the chart and draw another chart on the same position, you will have to remove the canvas tag after destroying the chart)

(you will notice brush disappearing for a short amount of time on tooltip, it will be visible again)

[TGilany]

Thanks, will check :)