Skip to content

Commit 124ae40

Browse files
authored
[General] Fix option check for update on startup (#980)
* Fixed option check for update on startup * Fixed review suggestion * Removed all unessecary || (or) * lint fix
1 parent cca09c0 commit 124ae40

1 file changed

Lines changed: 26 additions & 22 deletions

File tree

src/screens/Settings/index.tsx

Lines changed: 26 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ function Settings() {
9898
on: checkForUpdatesOnStartup,
9999
toggle: toggleCheckForUpdatesOnStartup,
100100
setOn: setCheckForUpdatesOnStartup
101-
} = useToggle(false)
101+
} = useToggle(true)
102102
const {
103103
on: nvidiaPrime,
104104
toggle: toggleNvidiaPrime,
@@ -202,43 +202,47 @@ function Settings() {
202202
'requestSettings',
203203
appName
204204
)
205-
setAutoSyncSaves(config.autoSyncSaves || false)
206-
setUseGameMode(config.useGameMode || false)
207-
setShowFps(config.showFps || false)
208-
setShowOffline(config.offlineMode || false)
209-
setAudioFix(config.audioFix || false)
210-
setShowMangoHud(config.showMangohud || false)
205+
setAutoSyncSaves(config.autoSyncSaves)
206+
setUseGameMode(config.useGameMode)
207+
setShowFps(config.showFps)
208+
setShowOffline(config.offlineMode)
209+
setAudioFix(config.audioFix)
210+
setShowMangoHud(config.showMangohud)
211211
setDefaultInstallPath(config.defaultInstallPath)
212212
setWineVersion(config.wineVersion)
213213
setWinePrefix(config.winePrefix)
214214
setWineCrossoverBottle(config.wineCrossoverBottle)
215215
setOtherOptions(config.otherOptions)
216216
setLauncherArgs(config.launcherArgs)
217-
setUseNvidiaPrime(config.nvidiaPrime || false)
217+
setUseNvidiaPrime(config.nvidiaPrime)
218218
setEgsLinkedPath(config.egsLinkedPath || '')
219219
setEgsPath(config.egsLinkedPath || '')
220-
setExitToTray(config.exitToTray || false)
221-
setStartInTray(config.startInTray || false)
222-
setDarkTrayIcon(config.darkTrayIcon || false)
223-
setDiscordRPC(config.discordRPC || false)
224-
setAutoInstallDxvk(config.autoInstallDxvk || false)
225-
setAutoInstallVkd3d(config.autoInstallVkd3d || false)
226-
setEnableEsync(config.enableEsync || false)
227-
setEnableFsync(config.enableFsync || false)
228-
setEnableFSR(config.enableFSR || false)
220+
setExitToTray(config.exitToTray)
221+
setStartInTray(config.startInTray)
222+
setDarkTrayIcon(config.darkTrayIcon)
223+
setDiscordRPC(config.discordRPC)
224+
setAutoInstallDxvk(config.autoInstallDxvk)
225+
setAutoInstallVkd3d(config.autoInstallVkd3d)
226+
setEnableEsync(config.enableEsync)
227+
setEnableFsync(config.enableFsync)
228+
setEnableFSR(config.enableFSR)
229229
setFsrSharpness(config.maxSharpness || 2)
230-
setResizableBar(config.enableResizableBar || false)
230+
setResizableBar(config.enableResizableBar)
231231
setSavesPath(config.savesPath || '')
232232
setMaxWorkers(config.maxWorkers ?? 0)
233233
setMaxRecentGames(config.maxRecentGames ?? 5)
234234
setCustomWinePaths(config.customWinePaths || [])
235-
setAddDesktopShortcuts(config.addDesktopShortcuts || false)
236-
setAddGamesToStartMenu(config.addStartMenuShortcuts || false)
235+
setAddDesktopShortcuts(config.addDesktopShortcuts)
236+
setAddGamesToStartMenu(config.addStartMenuShortcuts)
237237
setCustomWinePaths(config.customWinePaths || [])
238-
setCheckForUpdatesOnStartup(config.checkForUpdatesOnStartup || true)
238+
setCheckForUpdatesOnStartup(
239+
config.checkForUpdatesOnStartup !== undefined
240+
? config.checkForUpdatesOnStartup
241+
: true
242+
)
239243
setTargetExe(config.targetExe || '')
240244
setAltLegendaryBin(config.altLegendaryBin || '')
241-
setShowUnrealMarket(config.showUnrealMarket || false)
245+
setShowUnrealMarket(config.showUnrealMarket)
242246
setDefaultWinePrefix(config.defaultWinePrefix)
243247
setUseSteamRuntime(config.useSteamRuntime || false)
244248
if (!isDefault) {

0 commit comments

Comments
 (0)