Skip to content

Commit c502457

Browse files
authored
Bug fixes 6 (#58)
* fix: disabled sync buttons when no path * fix: small fixes
1 parent 16ab599 commit c502457

3 files changed

Lines changed: 6 additions & 3 deletions

File tree

.eslintcache

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
[{"/media/ssd480/Develop/Electron/heroic/src/index.tsx":"1","/media/ssd480/Develop/Electron/heroic/src/reportWebVitals.ts":"2","/media/ssd480/Develop/Electron/heroic/src/App.tsx":"3","/media/ssd480/Develop/Electron/heroic/src/helper.ts":"4","/media/ssd480/Develop/Electron/heroic/src/components/Library.tsx":"5","/media/ssd480/Develop/Electron/heroic/src/components/UI/GameCard.tsx":"6","/media/ssd480/Develop/Electron/heroic/src/components/UI/Header.tsx":"7","/media/ssd480/Develop/Electron/heroic/src/components/NavBar.tsx":"8","/media/ssd480/Develop/Electron/heroic/src/components/UI/UserSelector.tsx":"9","/media/ssd480/Develop/Electron/heroic/src/components/UI/SearchBar.tsx":"10","/media/ssd480/Develop/Electron/heroic/src/state/GlobalState.tsx":"11","/media/ssd480/Develop/Electron/heroic/src/state/ContextProvider.tsx":"12","/media/ssd480/Develop/Electron/heroic/src/components/UI/GamePage.tsx":"13","/media/ssd480/Develop/Electron/heroic/src/components/UI/ToggleSwitch.tsx":"14","/media/ssd480/Develop/Electron/heroic/src/components/UI/Update.tsx":"15","/media/ssd480/Develop/Electron/heroic/src/components/Settings/index.tsx":"16","/media/ssd480/Develop/Electron/heroic/src/components/Settings/GeneralSettings.tsx":"17","/media/ssd480/Develop/Electron/heroic/src/components/Settings/OtherSettings.tsx":"18","/media/ssd480/Develop/Electron/heroic/src/components/Settings/WineSettings.tsx":"19","/media/ssd480/Develop/Electron/heroic/src/components/Settings/Tools.tsx":"20","/media/ssd480/Develop/Electron/heroic/src/components/Settings/SyncSaves.tsx":"21","/media/ssd480/Develop/Electron/heroic/src/components/Login.tsx":"22","/media/ssd480/Develop/Electron/heroic/src/components/UI/InfoBox.tsx":"23"},{"size":587,"mtime":1610207662116,"results":"24","hashOfConfig":"25"},{"size":425,"mtime":1609009065758,"results":"26","hashOfConfig":"25"},{"size":1313,"mtime":1610837789190,"results":"27","hashOfConfig":"25"},{"size":2712,"mtime":1610837789193,"results":"28","hashOfConfig":"25"},{"size":648,"mtime":1610839171407,"results":"29","hashOfConfig":"25"},{"size":1022,"mtime":1610840840781,"results":"30","hashOfConfig":"25"},{"size":1158,"mtime":1610837789193,"results":"31","hashOfConfig":"25"},{"size":591,"mtime":1610837789190,"results":"32","hashOfConfig":"25"},{"size":1018,"mtime":1610207662113,"results":"33","hashOfConfig":"25"},{"size":870,"mtime":1610309174006,"results":"34","hashOfConfig":"25"},{"size":3080,"mtime":1610837789193,"results":"35","hashOfConfig":"25"},{"size":451,"mtime":1610207662116,"results":"36","hashOfConfig":"25"},{"size":10871,"mtime":1610840913653,"results":"37","hashOfConfig":"25"},{"size":336,"mtime":1610207662113,"results":"38","hashOfConfig":"25"},{"size":214,"mtime":1610207662113,"results":"39","hashOfConfig":"25"},{"size":6004,"mtime":1610837789190,"results":"40","hashOfConfig":"25"},{"size":4499,"mtime":1610904483015,"results":"41","hashOfConfig":"25"},{"size":1696,"mtime":1610904142044,"results":"42","hashOfConfig":"25"},{"size":2659,"mtime":1610903072095,"results":"43","hashOfConfig":"25"},{"size":870,"mtime":1610837789190,"results":"44","hashOfConfig":"25"},{"size":4730,"mtime":1610904376895,"results":"45","hashOfConfig":"25"},{"size":3136,"mtime":1610837789190,"results":"46","hashOfConfig":"25"},{"size":507,"mtime":1610902923461,"results":"47","hashOfConfig":"25"},{"filePath":"48","messages":"49","errorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0,"usedDeprecatedRules":"50"},"1uko0tc",{"filePath":"51","messages":"52","errorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0,"usedDeprecatedRules":"50"},{"filePath":"53","messages":"54","errorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0,"usedDeprecatedRules":"50"},{"filePath":"55","messages":"56","errorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0,"usedDeprecatedRules":"50"},{"filePath":"57","messages":"58","errorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0,"usedDeprecatedRules":"50"},{"filePath":"59","messages":"60","errorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0,"usedDeprecatedRules":"50"},{"filePath":"61","messages":"62","errorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0,"usedDeprecatedRules":"50"},{"filePath":"63","messages":"64","errorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0,"usedDeprecatedRules":"50"},{"filePath":"65","messages":"66","errorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0,"usedDeprecatedRules":"50"},{"filePath":"67","messages":"68","errorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0,"usedDeprecatedRules":"50"},{"filePath":"69","messages":"70","errorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0,"usedDeprecatedRules":"50"},{"filePath":"71","messages":"72","errorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0,"usedDeprecatedRules":"50"},{"filePath":"73","messages":"74","errorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0,"usedDeprecatedRules":"50"},{"filePath":"75","messages":"76","errorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0,"usedDeprecatedRules":"50"},{"filePath":"77","messages":"78","errorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0,"usedDeprecatedRules":"50"},{"filePath":"79","messages":"80","errorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0,"usedDeprecatedRules":"50"},{"filePath":"81","messages":"82","errorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"83","messages":"84","errorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"85","messages":"86","errorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"87","messages":"88","errorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0,"usedDeprecatedRules":"50"},{"filePath":"89","messages":"90","errorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"91","messages":"92","errorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0,"usedDeprecatedRules":"50"},{"filePath":"93","messages":"94","errorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},"/media/ssd480/Develop/Electron/heroic/src/index.tsx",[],["95","96"],"/media/ssd480/Develop/Electron/heroic/src/reportWebVitals.ts",[],"/media/ssd480/Develop/Electron/heroic/src/App.tsx",[],"/media/ssd480/Develop/Electron/heroic/src/helper.ts",[],"/media/ssd480/Develop/Electron/heroic/src/components/Library.tsx",[],"/media/ssd480/Develop/Electron/heroic/src/components/UI/GameCard.tsx",[],"/media/ssd480/Develop/Electron/heroic/src/components/UI/Header.tsx",[],"/media/ssd480/Develop/Electron/heroic/src/components/NavBar.tsx",[],"/media/ssd480/Develop/Electron/heroic/src/components/UI/UserSelector.tsx",[],"/media/ssd480/Develop/Electron/heroic/src/components/UI/SearchBar.tsx",[],"/media/ssd480/Develop/Electron/heroic/src/state/GlobalState.tsx",[],"/media/ssd480/Develop/Electron/heroic/src/state/ContextProvider.tsx",[],"/media/ssd480/Develop/Electron/heroic/src/components/UI/GamePage.tsx",[],"/media/ssd480/Develop/Electron/heroic/src/components/UI/ToggleSwitch.tsx",[],"/media/ssd480/Develop/Electron/heroic/src/components/UI/Update.tsx",[],"/media/ssd480/Develop/Electron/heroic/src/components/Settings/index.tsx",[],"/media/ssd480/Develop/Electron/heroic/src/components/Settings/GeneralSettings.tsx",[],"/media/ssd480/Develop/Electron/heroic/src/components/Settings/OtherSettings.tsx",[],"/media/ssd480/Develop/Electron/heroic/src/components/Settings/WineSettings.tsx",[],"/media/ssd480/Develop/Electron/heroic/src/components/Settings/Tools.tsx",[],"/media/ssd480/Develop/Electron/heroic/src/components/Settings/SyncSaves.tsx",[],"/media/ssd480/Develop/Electron/heroic/src/components/Login.tsx",[],"/media/ssd480/Develop/Electron/heroic/src/components/UI/InfoBox.tsx",[],{"ruleId":"97","replacedBy":"98"},{"ruleId":"99","replacedBy":"100"},"no-native-reassign",["101"],"no-negated-in-lhs",["102"],"no-global-assign","no-unsafe-negation"]
1+
[{"/media/ssd480/Develop/Electron/heroic/src/index.tsx":"1","/media/ssd480/Develop/Electron/heroic/src/reportWebVitals.ts":"2","/media/ssd480/Develop/Electron/heroic/src/App.tsx":"3","/media/ssd480/Develop/Electron/heroic/src/helper.ts":"4","/media/ssd480/Develop/Electron/heroic/src/components/Library.tsx":"5","/media/ssd480/Develop/Electron/heroic/src/components/UI/GameCard.tsx":"6","/media/ssd480/Develop/Electron/heroic/src/components/UI/Header.tsx":"7","/media/ssd480/Develop/Electron/heroic/src/components/NavBar.tsx":"8","/media/ssd480/Develop/Electron/heroic/src/components/UI/UserSelector.tsx":"9","/media/ssd480/Develop/Electron/heroic/src/components/UI/SearchBar.tsx":"10","/media/ssd480/Develop/Electron/heroic/src/state/GlobalState.tsx":"11","/media/ssd480/Develop/Electron/heroic/src/state/ContextProvider.tsx":"12","/media/ssd480/Develop/Electron/heroic/src/components/UI/GamePage.tsx":"13","/media/ssd480/Develop/Electron/heroic/src/components/UI/ToggleSwitch.tsx":"14","/media/ssd480/Develop/Electron/heroic/src/components/UI/Update.tsx":"15","/media/ssd480/Develop/Electron/heroic/src/components/Settings/index.tsx":"16","/media/ssd480/Develop/Electron/heroic/src/components/Settings/GeneralSettings.tsx":"17","/media/ssd480/Develop/Electron/heroic/src/components/Settings/OtherSettings.tsx":"18","/media/ssd480/Develop/Electron/heroic/src/components/Settings/WineSettings.tsx":"19","/media/ssd480/Develop/Electron/heroic/src/components/Settings/Tools.tsx":"20","/media/ssd480/Develop/Electron/heroic/src/components/Settings/SyncSaves.tsx":"21","/media/ssd480/Develop/Electron/heroic/src/components/Login.tsx":"22","/media/ssd480/Develop/Electron/heroic/src/components/UI/InfoBox.tsx":"23"},{"size":587,"mtime":1610207662116,"results":"24","hashOfConfig":"25"},{"size":425,"mtime":1609009065758,"results":"26","hashOfConfig":"25"},{"size":1313,"mtime":1610837789190,"results":"27","hashOfConfig":"25"},{"size":2712,"mtime":1610837789193,"results":"28","hashOfConfig":"25"},{"size":648,"mtime":1610905749972,"results":"29","hashOfConfig":"25"},{"size":1022,"mtime":1610905749976,"results":"30","hashOfConfig":"25"},{"size":1158,"mtime":1610837789193,"results":"31","hashOfConfig":"25"},{"size":591,"mtime":1610837789190,"results":"32","hashOfConfig":"25"},{"size":1018,"mtime":1610207662113,"results":"33","hashOfConfig":"25"},{"size":870,"mtime":1610309174006,"results":"34","hashOfConfig":"25"},{"size":3080,"mtime":1610837789193,"results":"35","hashOfConfig":"25"},{"size":451,"mtime":1610207662116,"results":"36","hashOfConfig":"25"},{"size":10871,"mtime":1610905749976,"results":"37","hashOfConfig":"25"},{"size":387,"mtime":1610905673782,"results":"38","hashOfConfig":"25"},{"size":214,"mtime":1610207662113,"results":"39","hashOfConfig":"25"},{"size":6004,"mtime":1610837789190,"results":"40","hashOfConfig":"25"},{"size":4499,"mtime":1610905749972,"results":"41","hashOfConfig":"25"},{"size":1696,"mtime":1610905749976,"results":"42","hashOfConfig":"25"},{"size":2659,"mtime":1610905749976,"results":"43","hashOfConfig":"25"},{"size":870,"mtime":1610837789190,"results":"44","hashOfConfig":"25"},{"size":4832,"mtime":1610905927585,"results":"45","hashOfConfig":"25"},{"size":3136,"mtime":1610837789190,"results":"46","hashOfConfig":"25"},{"size":507,"mtime":1610905749976,"results":"47","hashOfConfig":"25"},{"filePath":"48","messages":"49","errorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0,"usedDeprecatedRules":"50"},"1uko0tc",{"filePath":"51","messages":"52","errorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0,"usedDeprecatedRules":"50"},{"filePath":"53","messages":"54","errorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0,"usedDeprecatedRules":"50"},{"filePath":"55","messages":"56","errorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0,"usedDeprecatedRules":"50"},{"filePath":"57","messages":"58","errorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"59","messages":"60","errorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"61","messages":"62","errorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0,"usedDeprecatedRules":"50"},{"filePath":"63","messages":"64","errorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0,"usedDeprecatedRules":"50"},{"filePath":"65","messages":"66","errorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0,"usedDeprecatedRules":"50"},{"filePath":"67","messages":"68","errorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0,"usedDeprecatedRules":"50"},{"filePath":"69","messages":"70","errorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0,"usedDeprecatedRules":"50"},{"filePath":"71","messages":"72","errorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0,"usedDeprecatedRules":"50"},{"filePath":"73","messages":"74","errorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"75","messages":"76","errorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0,"usedDeprecatedRules":"50"},{"filePath":"77","messages":"78","errorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0,"usedDeprecatedRules":"50"},{"filePath":"79","messages":"80","errorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0,"usedDeprecatedRules":"50"},{"filePath":"81","messages":"82","errorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"83","messages":"84","errorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"85","messages":"86","errorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"87","messages":"88","errorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0,"usedDeprecatedRules":"50"},{"filePath":"89","messages":"90","errorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"91","messages":"92","errorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0,"usedDeprecatedRules":"50"},{"filePath":"93","messages":"94","errorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},"/media/ssd480/Develop/Electron/heroic/src/index.tsx",[],["95","96"],"/media/ssd480/Develop/Electron/heroic/src/reportWebVitals.ts",[],"/media/ssd480/Develop/Electron/heroic/src/App.tsx",[],"/media/ssd480/Develop/Electron/heroic/src/helper.ts",[],"/media/ssd480/Develop/Electron/heroic/src/components/Library.tsx",[],"/media/ssd480/Develop/Electron/heroic/src/components/UI/GameCard.tsx",[],"/media/ssd480/Develop/Electron/heroic/src/components/UI/Header.tsx",[],"/media/ssd480/Develop/Electron/heroic/src/components/NavBar.tsx",[],"/media/ssd480/Develop/Electron/heroic/src/components/UI/UserSelector.tsx",[],"/media/ssd480/Develop/Electron/heroic/src/components/UI/SearchBar.tsx",[],"/media/ssd480/Develop/Electron/heroic/src/state/GlobalState.tsx",[],"/media/ssd480/Develop/Electron/heroic/src/state/ContextProvider.tsx",[],"/media/ssd480/Develop/Electron/heroic/src/components/UI/GamePage.tsx",[],"/media/ssd480/Develop/Electron/heroic/src/components/UI/ToggleSwitch.tsx",[],"/media/ssd480/Develop/Electron/heroic/src/components/UI/Update.tsx",[],"/media/ssd480/Develop/Electron/heroic/src/components/Settings/index.tsx",[],"/media/ssd480/Develop/Electron/heroic/src/components/Settings/GeneralSettings.tsx",[],"/media/ssd480/Develop/Electron/heroic/src/components/Settings/OtherSettings.tsx",[],"/media/ssd480/Develop/Electron/heroic/src/components/Settings/WineSettings.tsx",[],"/media/ssd480/Develop/Electron/heroic/src/components/Settings/Tools.tsx",[],"/media/ssd480/Develop/Electron/heroic/src/components/Settings/SyncSaves.tsx",[],"/media/ssd480/Develop/Electron/heroic/src/components/Login.tsx",[],"/media/ssd480/Develop/Electron/heroic/src/components/UI/InfoBox.tsx",[],{"ruleId":"97","replacedBy":"98"},{"ruleId":"99","replacedBy":"100"},"no-native-reassign",["101"],"no-negated-in-lhs",["102"],"no-global-assign","no-unsafe-negation"]

src/components/Settings/SyncSaves.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -110,6 +110,7 @@ export default function SyncSaves({
110110
<select
111111
onChange={(event) => setSyncType(event.target.value as SyncType)}
112112
value={syncType}
113+
disabled={!Boolean(savesPath.length)}
113114
className="settingSelect small"
114115
>
115116
{syncTypes.map((name: SyncType) => (
@@ -132,6 +133,7 @@ export default function SyncSaves({
132133
Sync Saves Automatically
133134
<ToggleSwitch
134135
value={autoSyncSaves}
136+
disabled={!Boolean(savesPath.length)}
135137
handleChange={() => setAutoSyncSaves(!autoSyncSaves)}
136138
/>
137139
</span>

src/components/UI/ToggleSwitch.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,13 @@ import React from 'react'
33
interface Props {
44
handleChange: () => void
55
value: boolean
6+
disabled?: boolean
67
}
78

8-
export default function ToggleSwitch({handleChange, value}: Props) {
9+
export default function ToggleSwitch({handleChange, value, disabled}: Props) {
910
return (
1011
<label className="switch">
11-
<input checked={value} type="checkbox" onChange={handleChange} />
12+
<input disabled={disabled} checked={value} type="checkbox" onChange={handleChange} />
1213
<span className="slider round" />
1314
</label>
1415
)

0 commit comments

Comments
 (0)