Heroic creates empty $HOME/Games/Heroic on launch despite different default installation path

[boomlinde]

Describe the bug

I've set Default Installation Path under Settings/General to /home/boomlinde/docs/heroic (within my xdg-user-dir DOCUMENTS). This works, and games are installed under the configured path. Despite this, upon launch, Heroic creates the directory tree $HOME/Games/Heroic, which is then left empty and unused.

Add logs

(08:17:15) [INFO]:    [Backend]:         System Information: CPU: 12x 11th Gen Intel(R) Core(TM) i5-11400F @ 2.60GHz
Memory: 16.62 GB (used: 5.07 GB)
GPUs:
  GPU 0:
    Name: NVIDIA Corporation GA104 [GeForce RTX 3060 Ti]
    IDs: D=2486 V=10de SD=a632 SV=174b
    Driver: nvidia
OS: Void 6.12.53_1 (linux)

The current system is not a Steam Deck
We are running inside a Flatpak container

Software Versions:
  Heroic: 2.18.1 "Waterfall Beard" Jorul
  Legendary: 0.20.37 Exit 17 (Heroic)
  gogdl: 1.1.2
  comet: comet 0.2.0
  Nile: 1.1.2 Will A. Zeppeli
(08:17:15) [INFO]:    [Connection]:      Pinging external endpoints
(08:17:15) [INFO]:    [Connection]:      Connectivity: check-online
(08:17:15) [INFO]:    [Gog]:             Checking for existing gog manifests
(08:17:15) [WARNING]: [Backend]:         Failed to register protocol with OS.
(08:17:15) [INFO]:    [Legendary]:       Running command: LEGENDARY_CONFIG_PATH=/home/boomlinde/.var/app/com.heroicgameslauncher.hgl/config/heroic/legendaryConfig/legendary /app/bin/heroic/resources/app.asar.unpacked/build/bin/x64/linux/legendary --version
(08:17:15) [INFO]:    [Nile]:            Running command: NILE_CONFIG_PATH=/home/boomlinde/.var/app/com.heroicgameslauncher.hgl/config/heroic/nile_config /app/bin/heroic/resources/app.asar.unpacked/build/bin/x64/linux/nile --version
(08:17:15) [INFO]:    [Gog]:             Running command: GOGDL_CONFIG_PATH=/home/boomlinde/.var/app/com.heroicgameslauncher.hgl/config/heroic/gogdlConfig /app/bin/heroic/resources/app.asar.unpacked/build/bin/x64/linux/gogdl --auth-config-path /home/boomlinde/.var/app/com.heroicgameslauncher.hgl/config/heroic/gog_store/auth.json --version
(08:17:15) [DEBUG]:   [Legendary]:       Logging to file(s) "/home/boomlinde/.var/app/com.heroicgameslauncher.hgl/.local/state/Heroic/logs/runners/legendary.log"
(08:17:15) [DEBUG]:   [Nile]:            Logging to file(s) "/home/boomlinde/.var/app/com.heroicgameslauncher.hgl/.local/state/Heroic/logs/runners/nile.log"
(08:17:15) [DEBUG]:   [Gog]:             Logging to file(s) "/home/boomlinde/.var/app/com.heroicgameslauncher.hgl/.local/state/Heroic/logs/runners/gog.log"
(08:17:15) [INFO]:    [Connection]:      Connectivity: online
(08:17:15) [INFO]:    [Backend]:         User Not Found, removing it from Store
(08:17:15) [INFO]:    [Gog]:             Running command: GOGDL_CONFIG_PATH=/home/boomlinde/.var/app/com.heroicgameslauncher.hgl/config/heroic/gogdlConfig /app/bin/heroic/resources/app.asar.unpacked/build/bin/x64/linux/gogdl --auth-config-path /home/boomlinde/.var/app/com.heroicgameslauncher.hgl/config/heroic/gog_store/auth.json auth
(08:17:15) [INFO]:    [Gog]:             Checking if login is valid
(08:17:15) [INFO]:    [Gog]:             Running command: GOGDL_CONFIG_PATH=/home/boomlinde/.var/app/com.heroicgameslauncher.hgl/config/heroic/gogdlConfig /app/bin/heroic/resources/app.asar.unpacked/build/bin/x64/linux/gogdl --auth-config-path /home/boomlinde/.var/app/com.heroicgameslauncher.hgl/config/heroic/gog_store/auth.json auth
(08:17:15) [INFO]:    [Gog]:             Running command: GOGDL_CONFIG_PATH=/home/boomlinde/.var/app/com.heroicgameslauncher.hgl/config/heroic/gogdlConfig /app/bin/heroic/resources/app.asar.unpacked/build/bin/x64/linux/gogdl --auth-config-path /home/boomlinde/.var/app/com.heroicgameslauncher.hgl/config/heroic/gog_store/auth.json auth
(08:17:15) [DEBUG]:   [Gog]:             Logging to file(s) "/home/boomlinde/.var/app/com.heroicgameslauncher.hgl/.local/state/Heroic/logs/runners/gog.log"
(08:17:15) [DEBUG]:   [Gog]:             Logging to file(s) "/home/boomlinde/.var/app/com.heroicgameslauncher.hgl/.local/state/Heroic/logs/runners/gog.log"
(08:17:15) [DEBUG]:   [Gog]:             Logging to file(s) "/home/boomlinde/.var/app/com.heroicgameslauncher.hgl/.local/state/Heroic/logs/runners/gog.log"
(08:17:15) [INFO]:    [Backend]:         AreWeAntiCheatYet data downloaded
(08:17:15) [WARNING]: refresh not implemented on Sideload Library Manager
(08:17:15) [INFO]:    [Legendary]:       Refreshing library...
(08:17:15) [INFO]:    [Gog]:             Running command: GOGDL_CONFIG_PATH=/home/boomlinde/.var/app/com.heroicgameslauncher.hgl/config/heroic/gogdlConfig /app/bin/heroic/resources/app.asar.unpacked/build/bin/x64/linux/gogdl --auth-config-path /home/boomlinde/.var/app/com.heroicgameslauncher.hgl/config/heroic/gog_store/auth.json auth
(08:17:15) [INFO]:    [Frontend]:        Refreshing undefined Library
(08:17:15) [INFO]:    [Backend]:         Frontend Ready
(08:17:15) [DEBUG]:   [Gog]:             Logging to file(s) "/home/boomlinde/.var/app/com.heroicgameslauncher.hgl/.local/state/Heroic/logs/runners/gog.log"
(08:17:15) [INFO]:    [Gog]:             GOG presence set
(08:17:15) [INFO]:    [Gog]:             Getting GOG library
(08:17:15) [INFO]:    [Gog]:             Running command: GOGDL_CONFIG_PATH=/home/boomlinde/.var/app/com.heroicgameslauncher.hgl/config/heroic/gogdlConfig /app/bin/heroic/resources/app.asar.unpacked/build/bin/x64/linux/gogdl --auth-config-path /home/boomlinde/.var/app/com.heroicgameslauncher.hgl/config/heroic/gog_store/auth.json auth
(08:17:15) [DEBUG]:   [Gog]:             Logging to file(s) "/home/boomlinde/.var/app/com.heroicgameslauncher.hgl/.local/state/Heroic/logs/runners/gog.log"
(08:17:16) [INFO]:    [Gog]:             Saved username to config file
(08:17:16) [INFO]:    [Backend]:         Checking for current version changelog
(08:17:16) [WARNING]: No clientId in goggame-1207662513.info file. Cannot resolve save path
(08:17:16) [INFO]:    [Gog]:             Saved games data
(08:17:16) [WARNING]: listUpdateableGames not implemented on Sideload Library Manager
(08:17:16) [INFO]:    [Gog]:             Running command: GOGDL_CONFIG_PATH=/home/boomlinde/.var/app/com.heroicgameslauncher.hgl/config/heroic/gogdlConfig /app/bin/heroic/resources/app.asar.unpacked/build/bin/x64/linux/gogdl --auth-config-path /home/boomlinde/.var/app/com.heroicgameslauncher.hgl/config/heroic/gog_store/auth.json auth
(08:17:16) [DEBUG]:   [Gog]:             Logging to file(s) "/home/boomlinde/.var/app/com.heroicgameslauncher.hgl/.local/state/Heroic/logs/runners/gog.log"
(08:17:17) [INFO]:    [Gog]:             Found 0 game(s) to update
(08:17:17) [INFO]:    [Winetricks]:      Downloading Winetricks
(08:17:20) [INFO]:    [WineDownloader]:  Updating wine versions info
(08:17:20) [INFO]:    [WineDownloader]:  Fetching upstream information...
(08:17:20) [INFO]:    [Backend]:         Starting the Download Queue
(08:17:21) [INFO]:    [WineDownloader]:  wine versions updated

Steps to reproduce

1. Start Heroic
2. Change the Default Installation Path setting to something other than $HOME/Games/Heroic
3. Exit Heroic
4. Remove $HOME/Games/Heroic
5. Start Heroic
6. Verify that the directory was created with e.g. ls -d $HOME/Games/Heroic

Expected behavior

I expected it not to do this once having changed the default installation path. I purposely changed the default installation path not to have more directories created in my $HOME.

Screenshots

No response

Heroic Version

Latest Stable (Flatpak)

System Information

• OS [e. g. "Ubuntu"]: Void Linux

Additional information

No response

[CommandMC]

The Flatpak version of Heroic has this permission set in its manifest:

  - --filesystem=~/Games/Heroic:create

With :create added, the directory is automatically (re-)created if it's missing (Flatpak docs on FS permissions)
We can likely just drop the :create, install directories already get created if they're missing