Skip to content

Conversation

@a5ehren
Copy link
Contributor

@a5ehren a5ehren commented Jan 4, 2026

Notable updates that caused a bit of code churn are eslint and prettier.

The new eslint and especially its react rules do a bunch of checks around manual memoization because the React Compiler cannot do anything with those annotations - I've temporarily set a couple of the new options to Warnings until I can actually evaluate the performance impact of React Compiler to see if the code changes are worth it.


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

… changes.

Notable updates that caused a bit of code churn are eslint and prettier.

The new eslint and especially its react rules do a bunch of checks around manual memoization because the React Compiler cannot do anything with those annotations - I've temporarily set a couple of the new options to Warnings until I can actually evaluate the performance impact of React Compiler to see if the code changes are worth it.
@a5ehren a5ehren force-pushed the devdepends-update branch from de7a05f to a917a40 Compare January 4, 2026 20:35
@arielj
Copy link
Collaborator

arielj commented Jan 4, 2026

I'm not sure if having all these unrelated changes in the same PR is a good idea

some are comments, others are dependency updates, others move code around, others actually change code

I understand a lot is related to eslint and prettier, but looks off to me to merge the update of a dependency like axios at the same time as adding types for some variables and at the same time of refactoring some methods

@a5ehren
Copy link
Contributor Author

a5ehren commented Jan 5, 2026

Yeah, totally fair. I can split this into one that is the updates with zero code changes, then do prettier, then do eslint? Basically compartmentalize any update that needs code changes.

@a5ehren a5ehren closed this Jan 5, 2026
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Jan 5, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants