Merge pull request #21 from notFloran/typehint-and-php-73-deprecations

Add typehint and remove deprecation of FILTER_FLAG_SCHEME_REQUIRED in PHP 7.3

Author: Martin Damien

src/ImageEmbedPlugin.php

@@ -10,15 +10,12 @@
 
 class ImageEmbedPlugin implements Swift_Events_SendListener
 {
-
-    private $basePath = '';
-
     /**
-     * ImageEmbedPlugin constructor.
-     *
-     * @param string $basePath
+     * @var string
      */
-    public function __construct($basePath = '')
+    private $basePath;
+
+    public function __construct(string $basePath = '')
     {
         $this->basePath = $basePath;
     }
@@ -87,22 +84,12 @@ protected function embedImages(Swift_Mime_SimpleMessage $message, Swift_Mime_Sim
         return $dom->saveHTML();
     }
 
-    /**
-     * @param $path
-     *
-     * @return bool
-     */
-    protected function isUrl($path)
+    protected function isUrl(string $path) : bool
     {
-        return filter_var($path, FILTER_VALIDATE_URL, FILTER_FLAG_SCHEME_REQUIRED) !== false;
+        return filter_var($path, FILTER_VALIDATE_URL) !== false;
     }
 
-    /**
-     * @param $src
-     *
-     * @return string
-     */
-    protected function getPathFromSrc($src)
+    protected function getPathFromSrc(string $src) : string
     {
         if ($this->isUrl($src)) {
             return $src;
@@ -111,12 +98,7 @@ protected function getPathFromSrc($src)
         return $this->basePath . $src;
     }
 
-    /**
-     * @param $path
-     *
-     * @return bool
-     */
-    protected function fileExists($path)
+    protected function fileExists(string $path) : bool
     {
         if ($this->isUrl($path)) {
             return !!@getimagesize($path);